RE: SPAML: Re: R20.3 file transfer bug and fix

For feature requests and bug reports RC15 RC16. Please use the forum at http://forum.ultravnc.net/

Is the new code with the is available for download ? 

No need for MFC, it's dead already. But you could use ATL (or/and WTL)
libraries for some parts of the code. For instance for dialog templates,
since they could save you a lot of typing without introducing any runtime
overhead.

Best regards,
Yury

SmartCode Solutions
WWW: http://www.s-code.com
Tel: +1 (650) 276-0434 or +65 91125904
Fax: +1 (801) 904-5158

 

> -----Original Message-----
> From: [email protected] 
> [mailto:[email protected]] On Behalf Of Sam
> Sent: Monday, May 09, 2005 8:52 PM
> To: [email protected]
> Subject: SPAML: Re: [Ultravnc-list] R20.3 file transfer bug and fix
> 
> For feature requests and bug reports RC15 RC16. Please use 
> the forum at http://forum.ultravnc.net/
> 
> This bug has been fixed about 2 months ago.
> 
> By the way, the primary goal of our code is to make the job 
> correctly and efficiently, not to be styled or looking good.
> FYI, the codebase for FileTransfer was written in early 2002 
> in about 2 days, so I added at the beginning of the file (in 
> comments) that the code should be cleaned asap.
> 
> Anyway it will be rewritten as soon as V2 project is started, 
> but still without MFC neither .NET (all these things making 
> code looking good...)
> 
> Sam
> 
> 
> Yury Averkiev a écrit :
> 
> > Guys,
> > there is a buffer overflow bug at FileTransfer.cpp:3088 there you 
> > declare char szRemoteStatus[64];
> >  
> > and few lines down, there is a buffer overrun since you write more 
> > then 64 bytes to the buffer.
> >  
> > By the way, if I were you, I would trash the file transfer 
> dialog code 
> > completely and rewritten it from scratch. In his current state, the 
> > source code doesn't look any good at all...
> >
> > Best regards,
> > Yury
> >
> > SmartCode Solutions
> > WWW: _http://www.s-code.com_ <http://www.s-code.com/>
> > Tel: +1 (650) 276-0434 or +65 91125904
> > Fax: +1 (801) 904-5158
> >
> >  
> 
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games.
> Get your fingers limbered up and give it your best shot. 4 
> great events, 4 opportunities to win big! Highest score 
> wins.NEC IT Guy Games. Play to win an NEC 61 plasma display. 
> Visit http://www.necitguy.com/?r 
> 





-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.
Get your fingers limbered up and give it your best shot. 4 great events, 4
opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
win an NEC 61 plasma display. Visit http://www.necitguy.com/?r