Re: Another Patch
Andreas Hofmeister <[email protected]> Mon, 09 Feb 2004 09:14:34 +0100
| Newsgroups | gmane.network.zeroconf.workers |
|---|---|
| Message-ID | <[email protected]> |
Hi Steve and all, On Sun, 2004-02-08 at 21:21, Steve G wrote: > Hi, > > This patch is a combination of const > fixups, signed unsigned fixes, and corrections for the spec file, > init scripts, and the init.d makefiles. I fixed some compiler warnings and applied your patches to the cvs sources. I also extended the distro-check in configure.in (uses the rpm method), but I can not verify if that would work. > The MAXDNAME is 1025 and its compared with an > unsigned char. The unsigned char can only be 255 so the > comparison will always fail. Ooops, yes. The comparisions are actually needles and I removed them. It seems there is a difference between the maximum dname sizes implemented by the resolver lib and what DNS and mDNS actually may use. draft-ceshire...-03, Sect. 3.3 and RFC 1035 both state that domain names are at most 255 bytes long. I introduced another constant, MAXDSTRING that is used in places where a simple string is used and left MAXDNAME as limit for everything that is a domain name. Ciao Andi ------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn