Re: Intent to Implement and Ship: WebAudio: Event Constructors

--001a1146df0e2c8fd40540f4993c
Content-Type: text/plain; charset=UTF-8

LGTM2 with the spec fixed. I wouldn't mind looking at the CL, as it's
surprisingly easy to get things around optional dictionary arguments and
required dictionary members wrong. In particular, any event interface that
has non-nullable attributes of interface type, which is true of both of
these events, need to the corresponding dictionary members as required, or
something magical would have to happen when calling the constructor without
them.

On Thu, Nov 10, 2016 at 1:28 AM Rick Byers <[email protected]> wrote:

> Adding constructors makes sense - thanks!  But as spec'd these don't yet
> follow the standard event construction pattern.  Filed
> https://github.com/WebAudio/web-audio-api/issues/1067
>
> On Wed, Nov 9, 2016 at 2:26 PM, 'Alex Russell' via blink-dev <
> [email protected]> wrote:
>
> Glad to see this. It's great to have platform consistency where possible.
>
> On Wed, Nov 9, 2016 at 1:14 PM, Chris Harrelson <[email protected]>
> wrote:
>
> LGTM1
>
> On Wed, Nov 9, 2016 at 1:10 PM, 'Raymond Toy' via blink-dev <
> [email protected]> wrote:
>
> Contact emails
>
> [email protected], [email protected]
>
> Spec
>
> https://webaudio.github.io/web-audio-api/
>
> https://webaudio.github.io/web-audio-api/#OfflineAudioCompletionEvent
>
>
> https://webaudio.github.io/web-audio-api/#the-audioprocessingevent-interface---deprecated
>
> Summary
>
> Add constructors for the WebAudio events.
>
> Motivation
>
> Events are generally constructable, but the two WebAudio events were not.
> This makes these events match the typical Event model.
>
> See https://github.com/WebAudio/web-audio-api/issues/566 for the spec
> discussion.
>
> Interoperability and Compatibility Risk
>
> This is a new addition to the spec that will not affect backward
> compatibility.  We expect all browser to implement these constructors.
>
> Ongoing technical constraints
>
> None.
>
> Will this feature be supported on all six Blink platforms (Windows, Mac,
> Linux, Chrome OS, Android, and Android WebView)?
>
> Yes.
>
> OWP launch tracking bug
>
> http://crbug.com/662164
>
> Link to entry on the feature dashboard <https://www.chromestatus.com/>
>
> https://www.chromestatus.com/feature/5670531110010880
>
> Requesting approval to ship?
>
> Yes.
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].

--001a1146df0e2c8fd40540f4993c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">LGTM2 with the spec fixed. I wouldn&#39;t mind looking at =
the CL, as it&#39;s surprisingly easy to get things around optional diction=
ary arguments and required dictionary members wrong. In particular, any eve=
nt interface that has non-nullable attributes of interface type, which is t=
rue of both of these events, need to the corresponding dictionary members a=
s required, or something magical would have to happen when calling the cons=
tructor without them.</div><br><div class=3D"gmail_quote"><div dir=3D"ltr">=
On Thu, Nov 10, 2016 at 1:28 AM Rick Byers &lt;<a href=3D"mailto:rbyers@chr=
omium.org">[email protected]</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex"><div dir=3D"ltr" class=3D"gmail_msg">Adding constructors makes s=
ense - thanks!=C2=A0 But as spec&#39;d these don&#39;t yet follow the stand=
ard event construction pattern.=C2=A0 Filed=C2=A0<a href=3D"https://github.=
com/WebAudio/web-audio-api/issues/1067" class=3D"gmail_msg" target=3D"_blan=
k">https://github.com/WebAudio/web-audio-api/issues/1067</a></div><div clas=
s=3D"gmail_extra gmail_msg"><br class=3D"gmail_msg"><div class=3D"gmail_quo=
te gmail_msg">On Wed, Nov 9, 2016 at 2:26 PM, &#39;Alex Russell&#39; via bl=
ink-dev <span dir=3D"ltr" class=3D"gmail_msg">&lt;<a href=3D"mailto:blink-d=
[email protected]" class=3D"gmail_msg" target=3D"_blank">[email protected]=
rg</a>&gt;</span> wrote:<br class=3D"gmail_msg"><blockquote class=3D"gmail_=
quote gmail_msg" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr" class=3D"gmail_msg">Glad to see this. It&#39=
;s great to have platform consistency where possible.</div><div class=3D"m_=
2813209470790011072HOEnZb gmail_msg"><div class=3D"m_2813209470790011072h5 =
gmail_msg"><div class=3D"gmail_extra gmail_msg"><br class=3D"gmail_msg"><di=
v class=3D"gmail_quote gmail_msg">On Wed, Nov 9, 2016 at 1:14 PM, Chris Har=
relson <span dir=3D"ltr" class=3D"gmail_msg">&lt;<a href=3D"mailto:chrishtr=
@chromium.org" class=3D"gmail_msg" target=3D"_blank">[email protected]<=
/a>&gt;</span> wrote:<br class=3D"gmail_msg"><blockquote class=3D"gmail_quo=
te gmail_msg" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding=
-left:1ex"><div dir=3D"ltr" class=3D"gmail_msg">LGTM1</div><div class=3D"m_=
2813209470790011072m_-851910266447701171HOEnZb gmail_msg"><div class=3D"m_2=
813209470790011072m_-851910266447701171h5 gmail_msg"><div class=3D"gmail_ex=
tra gmail_msg"><br class=3D"gmail_msg"><div class=3D"gmail_quote gmail_msg"=
>On Wed, Nov 9, 2016 at 1:10 PM, &#39;Raymond Toy&#39; via blink-dev <span =
dir=3D"ltr" class=3D"gmail_msg">&lt;<a href=3D"mailto:[email protected]=
g" class=3D"gmail_msg" target=3D"_blank">[email protected]</a>&gt;</sp=
an> wrote:<br class=3D"gmail_msg"><blockquote class=3D"gmail_quote gmail_ms=
g" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">=
<div dir=3D"ltr" class=3D"gmail_msg"><span id=3D"m_2813209470790011072m_-85=
1910266447701171m_-3413235143791455515m_-5879447174137503554gmail-docs-inte=
rnal-guid-f710d31c-4aec-f027-0ed1-97536ffce5ef" class=3D"gmail_msg"><p dir=
=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=
=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:arial;color:r=
gb(0,0,0);font-weight:700;vertical-align:baseline;white-space:pre-wrap" cla=
ss=3D"gmail_msg">Contact emails</span></p><p dir=3D"ltr" style=3D"line-heig=
ht:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><a href=3D"ma=
ilto:[email protected]" style=3D"text-decoration-line:none" class=3D"gmail_=
msg" target=3D"_blank"><span style=3D"font-size:13.3333px;font-family:arial=
;text-decoration-line:underline;vertical-align:baseline;white-space:pre-wra=
p" class=3D"gmail_msg">[email protected]</span></a><span style=3D"font-size=
:13.3333px;font-family:arial;color:rgb(0,0,0);vertical-align:baseline;white=
-space:pre-wrap" class=3D"gmail_msg">, </span><a href=3D"mailto:hongchan@ch=
romium.org" style=3D"text-decoration-line:none" class=3D"gmail_msg" target=
=3D"_blank"><span style=3D"font-size:13.3333px;font-family:arial;text-decor=
ation-line:underline;vertical-align:baseline;white-space:pre-wrap" class=3D=
"gmail_msg">[email protected]</span></a></p><div dir=3D"ltr" style=3D"l=
ine-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><br c=
lass=3D"gmail_msg"></div><p dir=3D"ltr" style=3D"line-height:1.38;margin-to=
p:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span style=3D"font-size:13.33=
33px;font-family:arial;color:rgb(0,0,0);font-weight:700;vertical-align:base=
line;white-space:pre-wrap" class=3D"gmail_msg">Spec</span></p><p dir=3D"ltr=
" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmai=
l_msg"><a href=3D"https://webaudio.github.io/web-audio-api/" style=3D"text-=
decoration-line:none" class=3D"gmail_msg" target=3D"_blank"><span style=3D"=
font-size:13.3333px;font-family:arial;text-decoration-line:underline;vertic=
al-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">https://webaudi=
o.github.io/web-audio-api/</span></a></p><p dir=3D"ltr" style=3D"line-heigh=
t:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><a href=3D"htt=
ps://webaudio.github.io/web-audio-api/#OfflineAudioCompletionEvent" style=
=3D"text-decoration-line:none" class=3D"gmail_msg" target=3D"_blank"><span =
style=3D"font-size:13.3333px;font-family:arial;text-decoration-line:underli=
ne;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">https:=
//webaudio.github.io/web-audio-api/#OfflineAudioCompletionEvent</span></a><=
/p><p dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0p=
t" class=3D"gmail_msg"><a href=3D"https://webaudio.github.io/web-audio-api/=
#the-audioprocessingevent-interface---deprecated" style=3D"text-decoration-=
line:none" class=3D"gmail_msg" target=3D"_blank"><span style=3D"font-size:1=
3.3333px;font-family:arial;text-decoration-line:underline;vertical-align:ba=
seline;white-space:pre-wrap" class=3D"gmail_msg">https://webaudio.github.io=
/web-audio-api/#the-audioprocessingevent-interface---deprecated</span></a><=
/p><div dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:=
0pt" class=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=
=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg">=
<span style=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-=
weight:700;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg=
">Summary</span></p><p dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt=
;margin-bottom:0pt" class=3D"gmail_msg"><span style=3D"font-size:13.3333px;=
font-family:arial;color:rgb(0,0,0);vertical-align:baseline;white-space:pre-=
wrap" class=3D"gmail_msg">Add constructors for the WebAudio events.</span><=
/p><div dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:=
0pt" class=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=
=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg">=
<span style=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-=
weight:700;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg=
">Motivation</span></p><p dir=3D"ltr" style=3D"line-height:1.38;margin-top:=
0pt;margin-bottom:0pt" class=3D"gmail_msg"><span style=3D"font-size:13.3333=
px;font-family:arial;color:rgb(0,0,0);vertical-align:baseline;white-space:p=
re-wrap" class=3D"gmail_msg">Events are generally constructable, but the tw=
o WebAudio events were not.=C2=A0 This makes these events match the typical=
 Event model.</span></p><div dir=3D"ltr" style=3D"line-height:1.38;margin-t=
op:0pt;margin-bottom:0pt" class=3D"gmail_msg"><br class=3D"gmail_msg"></div=
><p dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt"=
 class=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:arial;c=
olor:rgb(0,0,0);vertical-align:baseline;white-space:pre-wrap" class=3D"gmai=
l_msg">See </span><a href=3D"https://github.com/WebAudio/web-audio-api/issu=
es/566" style=3D"text-decoration-line:none" class=3D"gmail_msg" target=3D"_=
blank"><span style=3D"font-size:13.3333px;font-family:arial;text-decoration=
-line:underline;vertical-align:baseline;white-space:pre-wrap" class=3D"gmai=
l_msg">https://github.com/WebAudio/web-audio-api/issues/566</span></a><span=
 style=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);vertical-a=
lign:baseline;white-space:pre-wrap" class=3D"gmail_msg"> for the spec discu=
ssion.</span></p><div dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;=
margin-bottom:0pt" class=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=
=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=
=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:arial;color:r=
gb(0,0,0);font-weight:700;vertical-align:baseline;white-space:pre-wrap" cla=
ss=3D"gmail_msg">Interoperability and Compatibility Risk</span></p><p dir=
=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=
=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:arial;color:r=
gb(0,0,0);vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg"=
>This is a new addition to the spec that will not affect backward compatibi=
lity.=C2=A0 We expect all browser to implement these constructors.</span></=
p><div dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0=
pt" class=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=
=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg">=
<span style=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-=
weight:700;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg=
">Ongoing technical constraints</span></p><p dir=3D"ltr" style=3D"line-heig=
ht:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span style=
=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);vertical-align:b=
aseline;white-space:pre-wrap" class=3D"gmail_msg">None.</span></p><div dir=
=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=
=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=3D"line-h=
eight:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span styl=
e=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-weight:700=
;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">Will thi=
s feature be supported on all six Blink platforms (Windows, Mac, Linux, Chr=
ome OS, Android, and Android WebView)?</span></p><p dir=3D"ltr" style=3D"li=
ne-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span =
style=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);vertical-al=
ign:baseline;white-space:pre-wrap" class=3D"gmail_msg">Yes.</span></p><div =
dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" cla=
ss=3D"gmail_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=3D"line=
-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span st=
yle=3D"font-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-weight:7=
00;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">OWP la=
unch tracking bug</span></p><p dir=3D"ltr" style=3D"line-height:1.38;margin=
-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><a href=3D"http://crbug.com=
/662164" style=3D"text-decoration-line:none" class=3D"gmail_msg" target=3D"=
_blank"><span style=3D"font-size:13.3333px;font-family:arial;text-decoratio=
n-line:underline;vertical-align:baseline;white-space:pre-wrap" class=3D"gma=
il_msg">http://crbug.com/662164</span><span style=3D"font-size:13.3333px;fo=
nt-family:arial;color:rgb(0,0,0);vertical-align:baseline;white-space:pre-wr=
ap" class=3D"gmail_msg"><span class=3D"m_2813209470790011072m_-851910266447=
701171m_-3413235143791455515m_-5879447174137503554gmail-Apple-tab-span gmai=
l_msg" style=3D"white-space:pre-wrap">	</span></span></a></p><div dir=3D"lt=
r" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=3D"gma=
il_msg"><br class=3D"gmail_msg"></div><p dir=3D"ltr" style=3D"line-height:1=
.38;margin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><span style=3D"fo=
nt-size:13.3333px;font-family:arial;color:rgb(0,0,0);font-weight:700;vertic=
al-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">Link to entry o=
n the </span><a href=3D"https://www.chromestatus.com/" style=3D"text-decora=
tion-line:none" class=3D"gmail_msg" target=3D"_blank"><span style=3D"font-s=
ize:13.3333px;font-family:arial;font-weight:700;text-decoration-line:underl=
ine;vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg">featu=
re dashboard</span></a></p><p dir=3D"ltr" style=3D"line-height:1.38;margin-=
top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><a href=3D"https://www.chrom=
estatus.com/feature/5670531110010880" style=3D"text-decoration-line:none" c=
lass=3D"gmail_msg" target=3D"_blank"><span style=3D"font-size:13.3333px;fon=
t-family:arial;text-decoration-line:underline;vertical-align:baseline;white=
-space:pre-wrap" class=3D"gmail_msg">https://www.chromestatus.com/feature/5=
670531110010880</span></a></p><div dir=3D"ltr" style=3D"line-height:1.38;ma=
rgin-top:0pt;margin-bottom:0pt" class=3D"gmail_msg"><br class=3D"gmail_msg"=
></div><p dir=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-botto=
m:0pt" class=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:a=
rial;color:rgb(0,0,0);font-weight:700;vertical-align:baseline;white-space:p=
re-wrap" class=3D"gmail_msg">Requesting approval to ship?</span></p><p dir=
=3D"ltr" style=3D"line-height:1.38;margin-top:0pt;margin-bottom:0pt" class=
=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-family:arial;color:r=
gb(0,0,0);vertical-align:baseline;white-space:pre-wrap" class=3D"gmail_msg"=
>Yes.</span></p><span class=3D"m_2813209470790011072m_-851910266447701171m_=
-3413235143791455515HOEnZb gmail_msg"><font color=3D"#888888" class=3D"gmai=
l_msg"><div class=3D"gmail_msg"><span style=3D"font-size:13.3333px;font-fam=
ily:arial;color:rgb(0,0,0);vertical-align:baseline;white-space:pre-wrap" cl=
ass=3D"gmail_msg"><br class=3D"gmail_msg"></span></div></font></span></span=
></div><span class=3D"m_2813209470790011072m_-851910266447701171m_-34132351=
43791455515HOEnZb gmail_msg"><font color=3D"#888888" class=3D"gmail_msg">

<p class=3D"gmail_msg"></p>

-- <br class=3D"gmail_msg">
You received this message because you are subscribed to the Google Groups &=
quot;blink-dev&quot; group.<br class=3D"gmail_msg">
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]" class=3D"gmai=
l_msg" target=3D"_blank">[email protected]</a>.<br class=
=3D"gmail_msg">
</font></span></blockquote></div><br class=3D"gmail_msg"></div>

<p class=3D"gmail_msg"></p>

-- <br class=3D"gmail_msg">
You received this message because you are subscribed to the Google Groups &=
quot;blink-dev&quot; group.<br class=3D"gmail_msg">
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]" class=3D"gmai=
l_msg" target=3D"_blank">[email protected]</a>.<br class=
=3D"gmail_msg">
</div></div></blockquote></div><br class=3D"gmail_msg"></div>

</div></div></blockquote></div><br class=3D"gmail_msg"></div>

</blockquote></div>

<p></p>

-- <br />
You received this message because you are subscribed to the Google Groups &=
quot;blink-dev&quot; group.<br />
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to <a href=3D"mailto:[email protected]">blink-dev+uns=
[email protected]</a>.<br />

--001a1146df0e2c8fd40540f4993c--