Re: tar tests require autom4te

Hanspeter Niederstrasser <[email protected]> Sat, 14 Sep 2013 07:40:49 -0400
Newsgroups gmane.os.apple.fink.core
Message-ID <[email protected]>
On 9/14/2013 6:00 AM, Max Horn wrote:
> Hi there,
>
> On 13.09.2013, at 14:53, Hanspeter Niederstrasser wrote:
>
>> Was updating tar on 10.7 to (B)Dep on libiconv-1.14 and ran into this
>> problem when it got to TestScript:
>
> [...]
>
>> Although this has a happy ending, if we ever modify tar test macros
>> again, this issue will reappear.
>
> Well, you added a comment to the .info file warning about that, so I hope we'll be fine.
>
> On a somewhat unrelated note, I noticed that our tar.info still uses the gross hack of running
>    %p/bin/fink -y install libgettext8-dev libiconv-dev
> in its CompileScript.
>
> I wonder if we really still need that... Out of curiosity, I created the attached modified version, which changes the above into a plain BDep (I also removed the relevant DescPackaging comments, custom CompileScript and "BuildAsNobody: false"). Oh, and (independent of the above) I cleaned up the InstallScript. I attached the result for reference.
>
> Then, I did a test bootstrap: No issues. I also did "fink -m rebuild tar" in my regular fink /sw tree, and it built fine.
>
> Perhaps there is some constellation where it is *not* going to work. Anybody got a clue whether that might be the case, and how I might trigger it?

Your revision fails for me with 'fink -m rebuild tar' in my regular tree:

35: no need to save dir with unreadable . and .. FAILED (extrac09.at:25)

I've attached the testsuite.log for this test, but the diagnostic part 
of the log is below:

----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----
--- /dev/null	2013-09-14 06:42:55.000000000 -0400
+++ 
/sw/build.build/tar-1.26-4/tar-1.26/tests/testsuite.dir/at-groups/35/stderr 
2013-09-14 06:42:55.000000000 -0400
@@ -0,0 +1,2 @@
+tar: unable to record current working directory: Permission denied
+cmp: extract/f: No such file or directory
./extrac09.at:25: exit code was 2, expected 0
35. extrac09.at:22: 35. no need to save dir with unreadable . and .. 
(extrac09.at:22): FAILED (extrac09.at:25)
----- 8< ----- 8< ----- 8< ----- 8< ----- 8< ----

Hanspeter

------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. 
http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk

_______________________________________________
fink-core mailing list
[email protected]
List archive:
http://news.gmane.org/gmane.os.apple.fink.core
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-core
testsuite.log (text/plain, 1 KB)
#                             -*- compilation -*-
35. extrac09.at:22: testing ...
./extrac09.at:25:
mkdir gnu
(cd gnu
TEST_TAR_FORMAT=gnu
export TEST_TAR_FORMAT
TAR_OPTIONS="-H gnu"
export TAR_OPTIONS
rm -rf *


echo test > 49077
chmod 0 49077
cat 49077 > /dev/null 2>&1
result=0
rm -f 49077
test  -eq 0 && exit 77


mkdir dir
mkdir dir/sub
mkdir dir/sub/extract
genfile --file dir/sub/f
cd dir/sub

tar -cf archive.tar f

chmod a-r . ..
tar -xvf archive.tar -C extract f
status=$?
chmod a+r . ..
cmp f extract/f || status=$?
exit $status
)
Not enabling shell tracing (command contains an embedded newline)
--- /dev/null	2013-09-14 06:42:55.000000000 -0400
+++ /sw/build.build/tar-1.26-4/tar-1.26/tests/testsuite.dir/at-groups/35/stderr	2013-09-14 06:42:55.000000000 -0400
@@ -0,0 +1,2 @@
+tar: unable to record current working directory: Permission denied
+cmp: extract/f: No such file or directory
./extrac09.at:25: exit code was 2, expected 0
35. extrac09.at:22: 35. no need to save dir with unreadable . and .. (extrac09.at:22): FAILED (extrac09.at:25)