tentative cause of make 4.1 regressions under fink

Jack Howarth <[email protected]>
Newsgroups gmane.os.apple.fink.devel
Message-ID <CAP5Ds0DjvcNu+o7otjzFu6WSZ1N4W78E8COYOkmmwYqPuqG7NQ@mail.gmail.com>
    So far my testing on 10.12 suggests that the trigger for the regression
in using fink make 4.1 under 10.12 is due to the flock() usage in
Services.pm. The most reliable reproducer of this regression on my system
has been the InfoTest of libcurl4 which always fails in the compilation of
the test suite under make 4.1. Using the following hack...

--- Services.pm.orig 2015-10-20 20:06:57.000000000 -0400
+++ Services.pm 2015-10-20 20:09:39.000000000 -0400
@@ -1756,11 +1756,11 @@
  }

  my $mode = $exclusive ? LOCK_EX : LOCK_SH;
- if (flock $lockfile_FH, $mode | LOCK_NB) {
- return wantarray ? ($lockfile_FH, 0) : $lockfile_FH;
- } else {
+# if (flock $lockfile_FH, $mode | LOCK_NB) {
+# return wantarray ? ($lockfile_FH, 0) : $lockfile_FH;
+# } else {
  # Maybe the system doesn't support locking?
- if ($! == EOPNOTSUPP || $! == ENOLCK) {
+# if ($! == EOPNOTSUPP || $! == ENOLCK) {
  require Fink::Config;
  if (!defined $Fink::Config::config ||
  !$Fink::Config::config->get_option("LockWarning", 0)) {
@@ -1772,7 +1772,7 @@
  if defined $Fink::Config::config;
  }
  return ($lockfile_FH, 0);
- }
+# }

  return (wantarray ? (0, 0) : 0) if $no_block;

@@ -1808,7 +1808,7 @@
  close $lockfile_FH;
  return wantarray ? (0, 0) : 0;
  }
- }
+# }
 }

 =item dpkg_lockwait

to avoid the flock() calls in perl suppresses the failure under make 4.1 on
10.12.

------------------------------------------------------------------------------

_______________________________________________
Fink-devel mailing list
[email protected]
List archive:
http://news.gmane.org/gmane.os.apple.fink.devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.