Re: git revision number for package update

> On Apr 23, 2020, at 9:14 AM, Hanspeter Niederstrasser <[email protected]> wrote:
> 
> New file mostly builds right. There are a few packaging issues:
> 
> 1) SourceRename: should use "fluidsynth-%v.tar.gz", not %N. If you use %N, the it renames to fluidsynth1-2.1.1.tar.gz, which does not match the internal folder. 'fluidsynth-2.1.1.tar.gz' is enough to tie the renamed tarball to a specific project.
> 
> 2) The build searches for readline but fails to detect it with readline6 installed. If you update the BuildDepends and Depends to use readline7, then it is detected and used.
> 
> 3) cmake find and uses pulseaudio and sdl2 if found. You'll have to either explicitly disable their use, or explicitly add them to the relevant Depends and BuildDepends fields across the SplitOffs.
> 
>>> Removing runtime build-lock...
>>> Removing build-lock package...
>>> /opt/sw/bin/dpkg-lockwait -r fink-buildlock-fluidsynth1-2.1.1-1
>>> (Reading database ... 44429 files and directories currently installed.)
>>> Removing fink-buildlock-fluidsynth1-2.1.1-1 ...
>>> Failed: directory /opt/sw/src/fink.build/fluidsynth1-2.1.1-1/fluidsynth1-2.1.1 doesn't exist, check the package description
>> (The installer is looking for “fluidsynth1-2.1.1-1/fluidynth-2.1.1”)
>> Many years ago, it was decided to rename the package “fluidsynth1”. I can’t remember exactly why. I will look at this issue later today.
> 
> The 1 refers to the library install_name (libfluidsynth.1.dylib, taken from otool -L libfluidsynth.1.dylib) and is used to allow different incompatible versions of the same package to exist at the same time. Version 2.1.1 of fluidsynth increased to library install_name to libfluidsynth.2.dylib, so the package will need to be renamed fluidsynth2, and fluidsynth2-dev package added to the Conflicts: and Replaces: fields.
> 
> In the original fluidsynth package, there must have been a conflict with the later fluidsynth1 package, so fluidsynth1 got hidden inside %p/lib/%N (see CMAKE_INSTALL_PREFIX) so that the two packages could co-exist. fluidsynth1 and what will be fluidsynth2 can probably coexist, so it might not be necessary to keep fluidsynth2 'hidden' anymore.
> 
> Hanspeter

Hanspeter,

Thank you very much for your comments which are extremely helpful. I will work on the issues that you have highlighted.

Sincerely,
Ebrahim

(Sometimes my messages to fink-devel bounce. I hope it goes through now.)

_______________________________________________
Fink-devel mailing list
[email protected]
List archive:
https://sourceforge.net/p/fink/mailman/fink-devel
Subscription management:
https://lists.sourceforge.net/lists/listinfo/fink-devel