Re: emacs26-app
Tomoaki Okayama <[email protected]> Wed, 6 May 2020 02:12:16 +0900
| Newsgroups | gmane.os.apple.fink.devel |
|---|---|
| Message-ID | <CALUjNcryWh=dabvFGm-4HD9aSzs7JyJmJ=UfjUn6mADuvvvvHQ@mail.gmail.com> |
--===============6239100365686949603== Content-Type: multipart/alternative; boundary="0000000000007f577b05a4e9c0e6" --0000000000007f577b05a4e9c0e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, the build-error of emacs26 seems the same as emacs26-app, so the patch for src/unexmacosx.c might work for emacs26 as well. Tomoaki Okayama 2020=E5=B9=B45=E6=9C=886=E6=97=A5(=E6=B0=B4) 1:59 Tomoaki Okayama <okayamat= @gmail.com>: > Hi Hanspeter, > > Thank you for your feedback. Attached please find new emacs26-app.info > and emacs26-app.patch based on your feedback. > > 1) Added your suggested field and code. > > 2) By applying an appropriate patch to configure, I deleted autogen.sh. > > 3) The build-error of emacs26 seems different from that of emacs26-app, > so I'm not sure on emacs26. (FYI: the main remedy for the build-error of > emacs26-app is a patch for src/unexmacosx.c, taken from upstream) > > Thank you for your suggestion on GitHub. I don't have enough knowledge > and time to do it, so please go ahead instead of me. > > Tomoaki Okayama > > 2020=E5=B9=B45=E6=9C=885=E6=97=A5(=E7=81=AB) 3:50 Hanspeter Niederstrasse= r <[email protected]>: > > > > On 5/4/20 9:20 AM, Tomoaki Okayama wrote: > > > Hi, > > > > > > I created emacs26-app.info and emacs26-app.patch, which seem > > > fine on macos 10.15.4. Not sure whether they work fine on 10.14 > > > or earlier, though. > > > > Hi Tomoaki, > > > > Can you submit this as a pull request in Github? It'll make discussion > > and tracking changes easier. > > https://github.com/fink/fink-distributions/pulls > > > > If you need git help, here's a quick primer on how to do it: > > > https://github.com/fink/fink-distributions/wiki/Submitting-new-or-updated= -packages > > > > Looking through your submission: > > 1) Can you add `SetCPPFLAGS: -MD` and then add a call to > > "fink-package-precedence --depfile-ext=3D'\.d' ." at the end of > > CompileScript? This will help you find missing dependencies. When I tes= t > > built your submission, I got hits for glib2-dev, gtk+2-dev, imagemagick= , > > and assorted image libraries. You'll either need to explicitly disable > > any of these that you don't want, or explicitly set (Build)Depends on > > them to get deterministic builds. > > > > 2) You run autogen.sh after patching configure and lib-src/Makefile.in. > > So those patches are overriden when autogen.sh is run and the files are > > re-generated. Is that on purpose? If so, please document it in > > DescPackaging since it's not the usual sequence. > > > > 3) It builds on 10.13/xcode10.1 and 10.15.4/xcode11.4.1. I don't use > > emacs, so I can't test anything besides saying it ran. Since this build= s > > on 10.15.4, do you know why our current emacs26 fails to build on > > 10.15.4/xcode11.4? > > https://sourceforge.net/p/fink/mailman/message/36984532/ > > > > Hanspeter > --0000000000007f577b05a4e9c0e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Sorry, the build-error of emacs26 seems the same as emacs2= 6-app,<div>so the patch for src/unexmacosx.c might work for emacs26 as well= .</div><div><br></div><div>Tomoaki Okayama</div></div><br><div class=3D"gma= il_quote"><div dir=3D"ltr" class=3D"gmail_attr">2020=E5=B9=B45=E6=9C=886=E6= =97=A5(=E6=B0=B4) 1:59 Tomoaki Okayama <<a href=3D"mailto:okayamat@gmail= .com">[email protected]</a>>:<br></div><blockquote class=3D"gmail_quote= " style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);= padding-left:1ex"><div dir=3D"ltr">Hi Hanspeter,<br><br>Thank you for your = feedback. Attached please find new <a href=3D"http://emacs26-app.info" targ= et=3D"_blank">emacs26-app.info</a><br>and emacs26-app.patch based on your f= eedback.<br><br>1) Added your suggested field and code.<br><br>2) By applyi= ng an appropriate patch to configure, I deleted autogen.sh.<br><br>3) The b= uild-error of emacs26 seems different from that of emacs26-app,<div>so I= 9;m not sure on emacs26. (FYI: the main remedy for the build-error of<div>e= macs26-app is a patch for src/unexmacosx.c, taken from upstream)<div><br>Th= ank you for your suggestion on GitHub. I don't have enough knowledge<br= >and time to do it, so please go ahead instead of me.<br><br>Tomoaki Okayam= a<br><br>2020=E5=B9=B45=E6=9C=885=E6=97=A5(=E7=81=AB) 3:50 Hanspeter Nieder= strasser <<a href=3D"mailto:[email protected]" target=3D"_blank">fi= [email protected]</a>>:<br>><br>> On 5/4/20 9:20 AM, Tomoaki Ok= ayama wrote:<br>> > Hi,<br>> ><br>> > I created <a href= =3D"http://emacs26-app.info" target=3D"_blank">emacs26-app.info</a> and ema= cs26-app.patch, which seem<br>> > fine on macos 10.15.4. Not sure whe= ther they work fine on 10.14<br>> > or earlier, though.<br>><br>&g= t; Hi Tomoaki,<br>><br>> Can you submit this as a pull request in Git= hub? It'll make discussion<br>> and tracking changes easier.<br>>= <a href=3D"https://github.com/fink/fink-distributions/pulls" target=3D"_bl= ank">https://github.com/fink/fink-distributions/pulls</a><br>><br>> I= f you need git help, here's a quick primer on how to do it:<br>> <a = href=3D"https://github.com/fink/fink-distributions/wiki/Submitting-new-or-u= pdated-packages" target=3D"_blank">https://github.com/fink/fink-distributio= ns/wiki/Submitting-new-or-updated-packages</a><br>><br>> Looking thro= ugh your submission:<br>> 1) Can you add `SetCPPFLAGS: -MD` and then add= a call to<br>> "fink-package-precedence --depfile-ext=3D'\.d&#= 39; ." at the end of<br>> CompileScript? This will help you find mi= ssing dependencies. When I test<br>> built your submission, I got hits f= or glib2-dev, gtk+2-dev, imagemagick,<br>> and assorted image libraries.= You'll either need to explicitly disable<br>> any of these that you= don't want, or explicitly set (Build)Depends on<br>> them to get de= terministic builds.<br>><br>> 2) You run autogen.sh after patching co= nfigure and lib-src/Makefile.in.<br>> So those patches are overriden whe= n autogen.sh is run and the files are<br>> re-generated. Is that on purp= ose? If so, please document it in<br>> DescPackaging since it's not = the usual sequence.<br>><br>> 3) It builds on 10.13/xcode10.1 and 10.= 15.4/xcode11.4.1. I don't use<br>> emacs, so I can't test anythi= ng besides saying it ran. Since this builds<br>> on 10.15.4, do you know= why our current emacs26 fails to build on<br>> 10.15.4/xcode11.4?<br>&g= t; <a href=3D"https://sourceforge.net/p/fink/mailman/message/36984532/" tar= get=3D"_blank">https://sourceforge.net/p/fink/mailman/message/36984532/</a>= <br>><br>> Hanspeter</div></div></div></div> </blockquote></div> --0000000000007f577b05a4e9c0e6-- --===============6239100365686949603== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============6239100365686949603== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Fink-devel mailing list [email protected] List archive: https://sourceforge.net/p/fink/mailman/fink-devel Subscription management: https://lists.sourceforge.net/lists/listinfo/fink-devel --===============6239100365686949603==--