Re: ptlib2.60-2.60-3 build problem on 10.5.6

On Sat, May 02, 2009 at 12:56:40AM +0200, Martin Costabel wrote:
> Alexander Hansen wrote:
> > Xcode 3.1.2.  The issue looks like something is expecting a different
> > argument list than Leopard provides:
> > 
> > ...
> > g++ -I/sw/src/fink.build/ptlib2.6.0-2.6.0-3/ptlib-2.6.0/include 
> > -Wno-long-double -DPTRACING=1 -D_REENTRANT  -I/sw/include   
> > -I/sw/include/SDL -D_GNU_SOURCE=1 -D_THREAD_SAFE   -fno-exceptions
> > -I/sw/include -Wall  -D__MACOSX__ -m486 -DNDEBUG -O2
> > -I/sw/src/fink.build/ptlib2.6.0-2.6.0-3/ptlib-2.6.0/include -fno-common
> > -dynamic -felide-constructors -Wreorder -I/sw/include -c
> > ptlib/unix/pipechan.cxx -o
> > /sw/src/fink.build/ptlib2.6.0-2.6.0-3/ptlib-2.6.0/lib_Darwin_x86/obj/pipechan.o
> > ptlib/unix/pipechan.cxx: In member function 'PBoolean
> > PPipeChannel::PlatformOpen(const PString&, const PStringArray&,
> > PPipeChannel::OpenMode, PBoolean, PBoolean, const PStringToString*)':
> > /usr/include/unistd.h:481: error: too many arguments to function 'pid_t
> > setpgrp()'
> 
> Didn't dmacks say a week ago on this list he'd look into this?
> 
> The setpgrp function changed its definition between Tiger (int
> setpgrp(pid_t pid, pid_t pgrp);) and Leopard (pid_t setpgrp(void);)
> 
> The ptlib sources are actually aware of this, they have (in 
> include/ptlib/unix/ptlib/pmachdep.h) the following piece of code:
> 
> > #elif defined (P_MACOSX) || defined(P_MACOS)
> > [some cursing of Apple omitted]
> > 
> > // hf, 2008-12-25: apparently, earlier versions of 10.5.x needed a version 
> > // without parameters. however, something changed such that the 'old' version
> > // is required again. (OS X 10.5.6)
> > #define PSETPGRP()  setpgrp(0, 0)
> 
> Apparently, they are wrong.

They've got a whole boatload of WRONG in their setpgrp handling.

Fix committed.


-- 
Daniel Macks
[email protected]
http://www.netspace.org/~dmacks


------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf