[fink:package-submissions] #4957 fix cvs for High Sierra's new snprintf strictness

Daniel Johnson via Fink-tracker <[email protected]>
Newsgroups gmane.os.apple.fink.tracker
Message-ID </p/fink/package-submissions/4957/1961486820fb1745b0ecc6b41e0c8cac68f9842c.package-submissions@fink.p.sourceforge.net>
- **status**: open --> closed-accepted
- **Group**: Awaiting_Packaging --> Added_to_Fink



---

** [package-submissions:#4957] fix cvs for High Sierra's new snprintf strictness**

**Status:** closed-accepted
**Group:** Added_to_Fink
**Created:** Sat Aug 12, 2017 11:53 AM UTC by Jack Howarth
**Last Updated:** Sat Aug 12, 2017 05:23 PM UTC
**Owner:** Daniel Macks


The following Info change and new patch fixes cvs on fink with the same approach Jeremy Huddleston Sequoia is using in MacPorts...

~~~
--- /sw/fink/10.13/stable/main/finkinfo/base/cvs.info	2015-09-10 16:42:29.000000000 -0400
+++ cvs.info	2017-08-12 07:43:54.000000000 -0400
@@ -1,7 +1,7 @@
 # -*- coding: ascii; tab-width: 4; x-counterpart: cvs.patch -*-
 Package: cvs
 Version: 1.12.13
-Revision: 18
+Revision: 19
 Maintainer: Daniel Johnson <[email protected]>
 #
 Conflicts: cvs-stable, cvs-proxy
@@ -10,6 +10,8 @@
 Source-MD5: 956ab476ce276c2d19d583e227dbdbea
 PatchFile: %n.patch
 PatchFile-MD5: c8f480b3d01d9ff1e980044274e1d192
+PatchFile2: %n-snprintf.patch
+PatchFile2-MD5: 25ace918b244283705e796d722cf2092
 ConfigureParams: <<
 --mandir=%p/share/man\
 --infodir=%p/share/info\
@@ -24,7 +26,7 @@
 SetCFLAGS: -D_DARWIN_NO_64_BIT_INODE -O2 -g -Wall
 BuildDepends: libgettext8-dev, libiconv-dev, fink (>= 0.30.0)
 Depends: libgettext8-shlibs, libiconv
-PatchScript: cat %{PatchFile} | patch -p0
+PatchScript: cat %{PatchFile} | patch -p0; cat %{PatchFile2} | patch -p1
 # Tests take a REALLY long time and I did get a failure.
 #InfoTest: <<
 # TestDepends: coreutils, gawk
@@ -79,6 +81,9 @@
  Added FreeBSD patch-64bit_crashfix, restore -O2 -g and add -Wall.
  Fixed K&R function parameter issue and uninitialized variables
  detected by clang.
+ With format string strictness, High Sierra also enforces that
+ %n isn't used in dynamic format strings, but we should just
+ disable its use on darwin in general.
 <<
 DescPort: <<
~~~

Tested with 'fink -m' and, once installed, 'fink selfupdate-cvs' on 10.13.

ps We will have to apply the same patch for other packages using this feature from gnulib.


---

Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/fink/package-submissions/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/fink/admin/package-submissions/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Fink-tracker mailing list
[email protected]
http://news.gmane.org/gmane.os.apple.fink.tracker
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.