[fink:package-submissions] #4974 fix gcc5 packaging to build against Xcode 9

Jack Howarth via Fink-tracker <[email protected]>
Newsgroups gmane.os.apple.fink.tracker
Message-ID </p/fink/package-submissions/4974/195211620bab28c68a27ad834e85ed635dbeba12.package-submissions@fink.p.sourceforge.net>
Note that I didn't revision bump this packaging as the changes for Xcode 9 are all header processing and don't change the code generated. No need to inflict an unnecessary rebuild on users not testing Xcode 9.


---

** [package-submissions:#4974] fix gcc5 packaging to build against Xcode 9**

**Status:** open
**Group:** Undergoing_Validation
**Created:** Mon Aug 21, 2017 12:23 AM UTC by Jack Howarth
**Last Updated:** Mon Aug 21, 2017 12:26 AM UTC
**Owner:** nobody


The attached gcc5 info file, revised gcc5-PR71767_PR57438_PR67710.patch and new gcc5-xcode9.patch allows the current gcc5-5.4.0-3 packaging to build against Xcode 9. The info file changes are...

~~~
Index: gcc5.info
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/languages/gcc5.info,v
retrieving revision 1.11
diff -u -r1.11 gcc5.info
--- gcc5.info	14 Nov 2016 01:25:40 -0000	1.11
+++ gcc5.info	20 Aug 2017 19:37:33 -0000
@@ -15,7 +15,9 @@
 # upsteam fix to avoid __textcoal_nt deprecated linker warnings
 # See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71767
 PatchFile3: %n-PR71767_PR57438_PR67710.patch
-PatchFile3-MD5: 4c4624e685c691399f7d26700aef6ee4
+PatchFile3-MD5: a3d829ef0ce865868a102c763f85a901
+PatchFile4: %n-xcode9.patch
+PatchFile4-MD5: c64f7fb0193324f39b031a076aff05d9
 PatchScript: <<
 	%{default_script}
 	# autoconf2.6ish patch for modern XQuartz paths
@@ -326,6 +328,11 @@
  PR71767 3/4 https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00539.html
  PR71767 4/4 https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00540.html
  PR57438 https://gcc.gnu.org/ml/gcc-patches/2016-11/msg00541.html
+
+ Manually backport https://github.com/gcc-mirror/gcc/commit/49622efa89937fa310add53b1efb50273ec0d857
+ and https://github.com/gcc-mirror/gcc/commit/ec8c949f8f296d1270fc41404175cd7249df4cd4 for Xcode 9.
+ Add const correct fix from https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00053.html for Xcode 9
+ to gcc5-PR71767_PR57438_PR67710.patch.
 <<
 Homepage: http://gcc.gnu.org/
 Maintainer: None <[email protected]>
~~~

The const-char fix from gcc trunk is applied to the relavent section in the current gcc5-PR71767_PR57438_PR67710.patch

~~~
Index: gcc5-PR71767_PR57438_PR67710.patch
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/languages/gcc5-PR71767_PR57438_PR67710.patch,v
retrieving revision 1.1
diff -u -r1.1 gcc5-PR71767_PR57438_PR67710.patch
--- gcc5-PR71767_PR57438_PR67710.patch	12 Nov 2016 09:57:51 -0000	1.1
+++ gcc5-PR71767_PR57438_PR67710.patch	20 Aug 2017 19:37:33 -0000
@@ -9331,10 +9331,10 @@
 +  if (vers_string != NULL)
 +    {
 +      char *asm_major = NULL;
-+      char *first_period = strchr(vers_string, '.');
++      const char *first_period = strchr(vers_string, '.');
 +      if (first_period != NULL)
 +	{
-+	  char *second_period = strchr(first_period+1, '.');
++	  const char *second_period = strchr(first_period+1, '.');
 +	  if (second_period  != NULL)
 +	    asm_major = xstrndup (vers_string, second_period-vers_string);
 +	  else
~~~

and the new gcc5-xcode9.patch backports the fixxes described in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81037

Tested on 10.13 with 'fink -m' against Xcode 9 beta 5.


---

Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/fink/package-submissions/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/fink/admin/package-submissions/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Fink-tracker mailing list
[email protected]
http://news.gmane.org/gmane.os.apple.fink.tracker
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.