[fink:package-submissions] #4994 skip broken test on APFS in python36 InfoTest

Jack Howarth via Fink-tracker <[email protected]>
Newsgroups gmane.os.apple.fink.tracker
Message-ID <59b09345c18baf3d4438b429.package-submissions@fink.p.sourceforge.net>


---

** [package-submissions:#4994] skip broken test on APFS in python36 InfoTest**

**Status:** open
**Group:** Undergoing_Validation
**Created:** Thu Sep 07, 2017 12:31 AM UTC by Jack Howarth
**Last Updated:** Thu Sep 07, 2017 12:31 AM UTC
**Owner:** Daniel Johnson


The current test_undecodable_filename is broken on APFS so the following Info file changes skips it when run on a APFS volume.

~~~
Index: python36.info
===================================================================
RCS file: /cvsroot/fink/dists/10.9-libcxx/stable/main/finkinfo/languages/python36.info,v
retrieving revision 1.5
diff -u -r1.5 python36.info
--- python36.info	21 Jul 2017 23:03:34 -0000	1.5
+++ python36.info	7 Sep 2017 00:25:58 -0000
@@ -53,6 +53,7 @@
 PatchFile: %n.patch
 PatchFile-MD5: 98b7ca7ac892ee6bcf3bd544bc2aa0da
 PatchScript: <<
+	#!/bin/sh -ex
 	sed 's|@PREFIX@|%p|g' < %{PatchFile} | patch -p1
 	# /tmp and /var/tmp are symlinks to /private/tmp and /private/var/tmp
 	# on OS X. That's fine except it can cause tests in some packages to
@@ -60,6 +61,13 @@
 	perl -pi -e "s|'/tmp', '/var/tmp'|'/private/tmp', '/private/var/tmp'|" Lib/tempfile.py
 	perl -pi -e 's/ -lSystemStubs//' ./configure
 	perl -pi -e 's/-O3/-fwrapv -O3/' ./configure
+	# Skip broken test on APFS that tries to explicitly to open(2) a file with a filename that is an illegal byte
+	# sequence and APFS returns EILSEQ a as a result.
+	# See  https://developer.apple.com/library/content/documentation/FileManagement/Conceptual/APFS_Guide/FAQ/FAQ.html
+	# APFS accepts only valid UTF-8 encoded filenames for creation, and preserves both case and normalization of the filename on disk in all variants.
+	if [ `diskutil info / | grep -c "APFS"` -gt 0 ] ; then
+		perl -pi -e "s|unittest.skipUnless\(support.TESTFN_UNDECODABLE|unittest.skipUnless\(0|" Lib/test/test_httpservers.py
+	fi
 <<
 
 UseMaxBuildJobs: true
~~~

Tested on 10.13 with 'fink -m'


---

Sent from sourceforge.net because [email protected] is subscribed to https://sourceforge.net/p/fink/package-submissions/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/fink/admin/package-submissions/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

_______________________________________________
Fink-tracker mailing list
[email protected]
http://news.gmane.org/gmane.os.apple.fink.tracker
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.