Re: [ITA] llvm

On Sat, 10 May 2025 18:46:12 +0200
ASSI wrote:
> Takashi Yano via Cygwin-apps writes:
> > Anyway I'll revise the cygport file. Any suggenstions
> > will be appreciated.
> 
> I've looked at the cygport in more detail, comments below.

Thanks for the advice!

I pushed updated llvm, clang, libcxx, libcxxabi, compiler-rt,
libunwind, and lld packages.

> Indentation is inconsistent.  I personally prefer not to use tabs and
> reduce indentation to four.
> 
> The bootstrapping should be enabled by (the presence of) variables in
> the build environment without the need to edit the cygport file.  Use
> "defined ENV_VAR" where possible and do not check for string content.
> Any dependencies between these variables should probably be enforced
> intead of just warned about.

Done.

> The packaging does not succeed if the build runs in a case-insensitive
> filesystem due to parallel usr/share/doc/{LLVM,llvm} directories.

The related paths are:
usr/share/doc/llvm              : llvm package (--exclude=html, --exclude=ocaml-html)
usr/share/doc/llvm/html/        : llvm-doc package
usr/share/doc/LLVM/polly/html/  : polly-doc package
usr/share/doc/llvm/ocaml-html/  : ocaml-llvm-doc package
usr/share/doc/LLVM/llvm/html/   : PKG_IGNORE

so I added --exclude=polly to llvm_CONTENTS and
replaced usr/share/doc/llvm with usr/share/doc/llvm/README.txt.

> It is not acceptable for the cygport to download files from the net
> and/or install any pre-requisites outside the build directory.  In other
> words, remove that curl invocation and use SRC_URI for that and cut out
> the pip3, that's what BUILD_REQUIRES are for (and yes, you will have to
> provide those packages if they don't already exist).

Done except for providing myst_parser package.

> Use the read-only convenience variables for referencing the package
> variables:
>  NAME                 -> PN
>  VERSION              -> PV
>  RELEASE              -> PR 
>  NAME-VERSION         -> P
>  NAME-VERSION-RELEASE -> PVR

Done.

> Bootstrapping llvm worked, but the tests can not be run due to missing
> googletest.

I ran llvm test and found it hangs around 90% progress.
I'll look into the issue.

-- 
Takashi Yano <[email protected]>