Re: libgit2

On 01/06/2025 02:40, Jeremy Drake via Cygwin-apps wrote:
> On Sat, 31 May 2025, Jon Turney wrote:
> 
>> On 26/05/2025 19:41, Jeremy Drake via Cygwin-apps wrote:
>>> On Sun, 25 May 2025, Jon Turney wrote:
>>>
>> [...]
>>>
>>> Should I add a big comment documenting the test failures, or a separate
>>> file?
>> No wrong answers.
>>
>> I guess I'd go for a separate file, but I don't mind.
>>
>>> PKG_NAMES="git2 libgit2_1_9 libgit2-devel"
>>
>> Sorry for not spotting this earlier, but I think the conventional name here is
>> "libgit2_1.9" (i.e. the underscore just separates the upstream name (when it
>> happens to end in digits) from a trailing soversion number, it doesn't replace
>> all the dots in it.
> 
> OK, wasn't sure, as soon as I saw that I was going to try to make a
> variable name with a dot in it, I went with the underscore.  But it seems
> I just stick with the underscore in the variable names.

Oh, right.

Characters in package names which aren't permitted in shell variable 
names are substituted with an '_'.

See, e.g.:

https://cygwin.github.io/cygport/pkg_pkg_cygpart.html#PKG_CONTENTS

  >> If we're going to package the 'git2' tool, maybe it should have a 
description
>> which makes it clearer what it's use is (debugging libgit2, not working with
>> git repor?)
> 
> I wouldn't be opposed to either not package it, or stick it in
> libgit2-devel.  I don't really know what it's used for tbh.
Me neither!

I pushed this so the package should get rebuilt and deployed. Now onto 
the rest...