Re: [PATCH] cygport cygclass/python.org.cygclass pythonhosted archives may require underscores not dashes

On 07/07/2025 09:48, Brian Inglis via Cygwin-apps wrote:
> On 2025-07-06 12:16, Jon Turney wrote:
>>
>> Please let me know if there are any problems.
>>
[...]
> Thanks Jon, get works fine now, tested with cygport 0.37.1 on py-lic- 
> expr deprecated and unreleased 30.4.2, but prep SRC_DIR needs to match 
> the distribution file name:

Oh, that's a bit disappointing.

As you might have guessed, I just tested that 'fetch' worked correctly 
and foolishly assumed that the testsuite would catch any problems during 
the build.

So either there's a missing test of this functionality (hopefully), or 
it's more complex than just arranging to also set SRC_DIR in this cygclass.

> $ cygport --debug python-license-expression.cygport get prep
> ...
>  >>> Unpacking source license_expression-30.4.2.tar.gz
> + defined unpack_out
> + ((  1 != 1  ))
> + '[' -n '' ']'
> + return 1
> + tar xf /var/cache/cygport/upstream/license_expression-30.4.2.tar.gz
> + '[' '!' -d /usr/src/python-license-expression/python-license- 
> expression-30.4.2-1.noarch/origsrc/license-expression-30.4.2 ']'
> + error 'SRC_DIR is not correctly defined'
> + case $? in
> + local errorcode=1
> + echo -e '\e[1;31m*** ERROR:\e[0;0m SRC_DIR is not correctly defined'
> *** ERROR: SRC_DIR is not correctly defined
> + exit 1
> $ ls -Gg python-license-expression-30.4.2-1.noarch/origsrc/
> total 8
> drwxr-xr-x 1 0 Jun 24 13:59 license_expression-30.4.2
> 
> The original PEPs have now been deprecated and the content moved into 
> the main PyPA specs which refer to normalization of binary and source 
> distribution and file names, following the binary distribution file name 
> rules s/[-._]/_/g etc. to remove any excess hyphens or dots from source 
> and binary distribution and file names, including distribution archive 
> directory and metadata names which must match, but not PyPI package or 
> project names which remain unnormalized.
> 
> https://packaging.python.org/en/latest/specifications/source- 
> distribution-format/
I have no idea if this is telling me some action needs to be taken, or 
if this is all just for information.