Re: [ITA] llvm
Takashi Yano via Cygwin-apps <[email protected]>
| Newsgroups | gmane.os.cygwin.applications |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 9 Jul 2025 23:27:10 -0700 (PDT)
Jeremy Drake wrote:
> I just saw you updated some patches. Most of the patches are now already
> upstream and are included to backport to 20.1.x.
> (https://github.com/msys2/MSYS2-packages/blob/master/llvm/README-patches.md)
> Specifically, your modification to the clang 0110 patch adding a Cygwin
> toolchain should be a followup patch because 0110 patch is
> https://github.com/llvm/llvm-project/commit/52924a2d7255cdd280b2b82dad8616e01fe065da
OK. I'll make a separate patch from 0110.
> I had been intending to get back to a follow-up PR to be able to call the
> linker directly, but never did. I was thinking about maybe trying to
> derive from the MinGW linker...
I have borrow the code mainly from Gnu.cpp and some code from MinGW.cpp.
> Also, I am confused about #define-ing constinit in the libc++ patches. Is
> there still some issue with constinit?
Without this patch, I have seen errors like:
libcxx-20.1.7-1.x86_64/src/libcxx-20.1.7.src/src/random_shuffle.cpp:22:35: error: variable does not have a constant initializer
22 | static constinit __libcpp_mutex_t __rs_mut = _LIBCPP_MUTEX_INITIALIZER;
| ^ ~~~~~~~~~~~~~~~~~~~~~~~~~
I'm using gcc v12.4.0. Using gcc 13 may solves the issue?
--
Takashi Yano <[email protected]>