Re: [PATCH chere 0/4] Overview of chere patches

Hello Vadim,

Thank you for this useful patch.
Additional comments inlined below...

On 8/6/2025 6:54 AM, Vadim (vadcx) via Cygwin-apps wrote:
> From: "Vadim (vadcx)" <[email protected]>
> 
> I started the commits backwards, so forgive me the dirty rebase where
> feature commits touch many adjacent lines as part of the quoting
> cleanup. I've already spent more time than I'm willing to admit.

I know that feeling...  I have no comment on this work just yet.
> Since a review of the last quoting commit may take a long time and be
> considered "controversial" by some folk (like "why does he quote all
> this"), it's last in case you want to drop it. I follow a very
> conservative approach, guided by Shellcheck, to quote as much as
> possible to leave no room for error in the future. Some variables are
> word-split on purpose. Ideally I'd want them converted to bash arrays,
> but that's too much work for now and not sure if it'd be accepted.
> 
> Did I use the correct upstream for my git clone? repo.or.cz/chere.git

I'll need to research this.  Even though I've adopted chere, I've only 
been aware of the chere script itself, not xhere nor the man page.  I 
need to get my local repository in shape first in order to support.
> *Further work*
> 1. As TODO states, automatically elevate privileges using UAC
> (see my next feature patch to cygutils/cygstart)
> 2. Populate icon and more fields in Uninstaller entry
> 3. Consider inclusion in Cygwin installer as a user choice? Then chere
> would need to be way more robust and not just fail on lack of rights
> and an exit code of 0.
> 4. Consider rewriting uninstaller to call a Batch script, chicken and
> egg problem as it requires Cygwin env to uninstall itself.

These seem like plausible future work items; is there a TODO file in the 
package you could add these to?  Or maybe create one in another patch?

> Vadim (vadcx) (4):
>    chere: fix list command
>    chere: add icon to context menu
>    chere: change default terminal to mintty and echo selected terminal
>    chere and xhere: clean up bash syntax
> 
>   src/chere | 352 ++++++++++++++++++++++++++++--------------------------
>   src/xhere |  17 +--
>   2 files changed, 192 insertions(+), 177 deletions(-)
Thanks & Regards,

..mark