Re: [PATCH chere 0/4] Overview of chere patches
Mark Geisert via Cygwin-apps <[email protected]>
| Newsgroups | gmane.os.cygwin.applications |
|---|---|
| Message-ID | <[email protected]> |
Hi Vadim, On 8/8/2025 6:05 AM, Vadim (vadcx) via Cygwin-apps wrote: > On 8/8/25 10:58, Mark Geisert wrote: > >>> *Further work* >>> 1. As TODO states, automatically elevate privileges using UAC >>> (see my next feature patch to cygutils/cygstart) >>> 2. Populate icon and more fields in Uninstaller entry >>> 3. Consider inclusion in Cygwin installer as a user choice? Then chere >>> would need to be way more robust and not just fail on lack of rights >>> and an exit code of 0. >>> 4. Consider rewriting uninstaller to call a Batch script, chicken and >>> egg problem as it requires Cygwin env to uninstall itself. >> >> These seem like plausible future work items; is there a TODO file in >> the package you could add these to? Or maybe create one in another >> patch? > Hi Mark, > > yes indeed, there's a TODO in the file in comments at the top. My own > notes came as an afterthought, which is why it's in the patch overview. > I can work towards some of these items in chere, now that I know there's > someone to potentially accept my patches :) > > If you want me to add this paragraph to code now - not a problem. Is it > OK to attach it as a 5/5 patch to the current series? I think it could > be applied out of order anyway, without conflicts. I've been advised off-list that chere is not currently in the cygwin-apps git repository. I will work on getting the current release version situated there as a known-good base. Then I'll review and likely apply your patches, then build a test release. If you want to work on a 5/5 patch, feel free. I can easily add it to the test release before final release of the new version. Thanks & Regards, ..mark