Re: CYGWIN_FILES confusion

On 25/09/2025 20:17, Andrew Schulman via Cygwin-apps wrote:
> On Thu, 25 Sep 2025 19:06:32 +0100, Jon Turney via Cygwin-apps
> <cygwin-apps-rDBXBDvO6BXQT0dZR+AlfA-XMD5yJDbdMReXY1tMh2IBg-XMD5yJDbdMReXY1tMh2IBg@public.gmane.org> wrote:
> 
>> On 25/09/2025 17:27, Andrew Schulman via Cygwin-apps wrote:
>>> In screen.cygport, I have
>>>
>>> CYGWIN_FILES="
>>>       CYGWIN-PATCHES/README
>>>       CYGWIN-PATCHES/colortest.sh
>>> "
>>>
>>> cygport is happy with this. It reads ${top}/CYGWIN-PATCHES/README et al. and
>>> installs them correctly.
>>>
>>> However calm doesn't like it. From
>>> https://github.com/cygwin/scallywag/actions/runs/18013629781/job/51252720116:
>>>
>>>>>> Creating source package
>>> cp: cannot stat
>>> '/cygdrive/d/a/scallywag/screen/screen-5.0.1-3.x86_64/src/screen-5.0.1/CYGWIN-PATCHES/CYGWIN-PATCHES/README':
>>> No such file or directory
>>>
>>> Note that calm is looking in ${S}/CYGWIN-PATCHES/CYGWIN-PATCHES.
>>
>> Huh.
>>
>> I think only anticipated this would be used with simple filenames, and
>> that's probably all I've tested it with.
>>
>> You shouldn't need to prefix the filenames in CYGWIN_FILES with
>> "CYGWIN_PATCHES/". Does it not work in that form?
> 
> Right - forgot to mention that I tried that. With
> 
> CYGWIN_FILES="
>      README
>      colortest.sh
> "
> 
> my local cygport quits with
> 
> cp: cannot stat '/home/Andrew/dev/cygwin/screen/README': No such file or
> directory

Uh?

I think the idea is that files named in CYGWIN_FILES will be at the same 
level as the cygport (and thus are placed in the top level of the source 
package)

>> Maybe there's a bug here, or the documentation need a bit of improvement?
> 
> It does seem that my local cygport and calm's cygport are expecting
> CYGPORT_FILES to be relative to different directories. The documentaton for
> CYGPORT_FILES
> (https://cygwin.github.io/cygport/src_prep_cygpart.html#CYGWIN_FILES) doesn't
> say what directory that should be, so I thought it should be $top.
> 
> I also tried making them absolute paths, but that bombed too - local cygport
> tried to make them relative to $top anyway.
You're also going rather unnecessarily around the houses with 
colortest.sh here, though.

If the file doesn't fall into the cases which get special handling 
described in the reference manual section for ${C}, you can/should just 
add it to SRC_URI and install from ${S}.