Re: [PATCH bash] Use the same IMP macro for Aarch64 as for x86_64

Hi,

Thanks for the response!

On 5/24/2026 4:04 PM, Jon Turney wrote:
> On 19/05/2026 08:23, Mate Dimand via Cygwin-apps wrote:
>> Hi,
>>
>> While testing Bash on ARM64, we found that this change is necessary 
>> for compilation to succeed, because the ARM64 compiled version of 
>> libreadline also uses the "__imp_" prefix.
>
> Thanks!
>
> I applied this so it wont get forgotten, even though we don't have any 
> means to build this right now.
>
> Would I be correct in inferring that this means that there are no 
> aarch64 specific patches needed for the various build dependencies of 
> bash?
Porting bash to aarch64 is still in progress, we might need other 
patches (either in Cygwin, bash, or bash's dependencies) but at the 
moment I can't tell for sure.
> In the future, if possible, please attach your patches, preferably 
> produced by 'git format-patch' and against the packaging repository.
> (in this case, https://cygwin.com/cgit/cygwin-packages/bash/)
>
> (This was small enough that making the change manually was possible, 
> since it had some kind of newline damage that meant that trying to 
> apply it had me pulling my hair out...) 

Sorry for the trouble, I will make sure to use 'git format-patch' next 
time. Could you be more specific about creating the patch against the 
package repository?
I created the submitted patch against a mirror of it, so I am unsure 
what I will need to do differently about that next time.

Best regards,
Máté Dimand