[newlib-cygwin/main] Cygwin: dumper: allow compiling with binutils 2.47

Jon Turney via Cygwin-cvs <[email protected]> Mon, 3 Aug 2026 14:03:06 +0000 (GMT)
Newsgroups gmane.os.cygwin.cvs
Message-ID <[email protected]>
https://sourceware.org/git/gitweb.cgi?p=3Dnewlib-cygwin.git;h=3Dec3607ba28c=
d28cd031ef788a67a3037ff8f9f5c

commit ec3607ba28cd28cd031ef788a67a3037ff8f9f5c
Author: Johannes Schindelin <[email protected]>
Date:   Tue Jul 28 10:48:45 2026 +0200

    Cygwin: dumper: allow compiling with binutils 2.47
   =20
    In the latest version, binutils' BFD no longer declares a `bfd_boolean`,
    and the `bfd_record_phdr()` function accepts plain `bool` parameters
    instead.
   =20
    Let's accommodate for that to avoid these build failures:
   =20
      .../winsup/utils/dumper.cc: In member function 'int dumper::prepare_c=
ore_dump()':
      .../winsup/utils/dumper.cc:830:7: error: 'bfd_boolean' was not declar=
ed in this scope; did you mean 'boolean'?
        830 |       bfd_boolean filehdr =3D 0;
            |       ^~~~~~~~~~~
            |       boolean
      .../winsup/utils/dumper.cc:831:18: error: expected ';' before 'phdrs'
        831 |       bfd_boolean phdrs =3D 0;
            |                  ^~~~~~
            |                  ;
      [...]
   =20
    Signed-off-by: Johannes Schindelin <[email protected]>

Diff:
---
 winsup/utils/dumper.cc | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/winsup/utils/dumper.cc b/winsup/utils/dumper.cc
index d8c4a530e..19b1ec257 100644
--- a/winsup/utils/dumper.cc
+++ b/winsup/utils/dumper.cc
@@ -839,14 +839,14 @@ dumper::prepare_core_dump ()
       p->section =3D new_section;
       int section_count =3D 1;
=20
-      bfd_boolean filehdr =3D 0;
-      bfd_boolean phdrs =3D 0;
+      bool filehdr =3D false;
+      bool phdrs =3D false;
=20
       bfd_vma at =3D 0;
-      bfd_boolean valid_at =3D 0;
+      bool valid_at =3D false;
=20
       flagword flags =3D 0;
-      bfd_boolean valid_flags =3D 1;
+      bool valid_flags =3D true;
=20
       if (p->type =3D=3D pr_ent_memory)
 	{