Re: [PATCH] dumper: allow compiling with binutils 2.47

On 28/07/2026 11:39, Johannes Schindelin via GitGitGadget wrote:
> From: Johannes Schindelin <[email protected]>
> 
> In the latest version, binutils' BFD no longer declares a `bfd_boolean`,
> and the `bfd_record_phdr()` function accepts plain `bool` parameters
> instead.
> 
> Let's accommodate for that to avoid these build failures:

The obvious question I would ask is "does it still build with older 
bfd", to which the answer seems to be "yes".

So, applied. Thanks!

> 
>    .../winsup/utils/dumper.cc: In member function 'int dumper::prepare_core_dump()':
>    .../winsup/utils/dumper.cc:830:7: error: 'bfd_boolean' was not declared in this scope; did you mean 'boolean'?
>      830 |       bfd_boolean filehdr = 0;
>          |       ^~~~~~~~~~~
>          |       boolean
>    .../winsup/utils/dumper.cc:831:18: error: expected ';' before 'phdrs'
>      831 |       bfd_boolean phdrs = 0;
>          |                  ^~~~~~
>          |                  ;
>    [...]
> 
> Signed-off-by: Johannes Schindelin <[email protected]>
> ---
>      dumper: allow compiling with binutils 2.47
>      
[...]