Re: [PATCH v2] exceptions: Fix AArch64 non-incyg signal handling

Jon Turney <[email protected]> Mon, 3 Aug 2026 17:02:20 +0100
Newsgroups gmane.os.cygwin.patches
Message-ID <[email protected]>
On 15/07/2026 14:22, Máté Dimand wrote:
> Hi everyone,
> 
> I have resolved the concerns raised by Jon Turney about nested signal 
> handling in the previous version by taking a different approach.

Thanks very much for taking another look at this.

Sorry about the delay in finding some time to look at it!


After raising the concern about the potential for nested signals, I was 
vaguely thinking "can't we stash the context on the stack in sigdelayed 
rather than having a single instance", so this implementation fits my 
prejudices. :)


I applied this, but I have a couple of follow up questions:

cygtls::sigdelayed_impl could probably be marked with 
__attribute__((noreturn))?

Elsewhere ([1], in the implementation of setcontext), the claim is made 
that RtlRestoreContext() can fail on synthetic contexts (meaning, not 
directly the result of RtlCaptureContext()).

Do you agree? Is there good reason to believe that the manipulations we 
perform on a context here are "safe"?

[1] https://cygwin.com/pipermail/cygwin-patches/2026q3/015206.html