Re: [PATCH] dumper: allow compiling with binutils 2.47

Hi Jon,

On Mon, 3 Aug 2026, Jon Turney wrote:

> On 28/07/2026 11:39, Johannes Schindelin via GitGitGadget wrote:
> > From: Johannes Schindelin <[email protected]>
> >=20
> > In the latest version, binutils' BFD no longer declares a `bfd_boolean=
`,
> > and the `bfd_record_phdr()` function accepts plain `bool` parameters
> > instead.
> >=20
> > Let's accommodate for that to avoid these build failures:
>=20
> The obvious question I would ask is "does it still build with older
> bfd", to which the answer seems to be "yes".
>=20
> So, applied. Thanks!

Thank you!
Johannes

>=20
> >=20
> >    .../winsup/utils/dumper.cc: In member function 'int
> >    dumper::prepare_core_dump()':
> >    .../winsup/utils/dumper.cc:830:7: error: 'bfd_boolean' was not decl=
ared
> >    in this scope; did you mean 'boolean'?
> >      830 |       bfd_boolean filehdr =3D 0;
> > |       ^~~~~~~~~~~
> > |       boolean
> >    .../winsup/utils/dumper.cc:831:18: error: expected ';' before 'phdr=
s'
> >      831 |       bfd_boolean phdrs =3D 0;
> > |                  ^~~~~~
> > |                  ;
> >    [...]
> >=20
> > Signed-off-by: Johannes Schindelin <[email protected]>
> > ---
> >      dumper: allow compiling with binutils 2.47
> >     =20
> [...]
>=20