Re: dynamic conpty loading
Brian Inglis via Cygwin <[email protected]>
| Newsgroups | gmane.os.cygwin |
|---|---|
| Organization | Systematic Software |
| Message-ID | <[email protected]> |
On 2025-12-05 02:52, Takashi Yano via Cygwin wrote: > Hi Corinna, > Thanks for the comment. > On Thu, 4 Dec 2025 12:01:58 +0100 > Corinna Vinschen wrote: >> On Dec 3 17:56, Takashi Yano via Cygwin wrote: >>> Subject: [PATCH v2] Cygwin: pty: Experimental OpenConsole.exe support >> Some commit message here? Yeah, I know, it's just experimental for now :) >> >>> Signed-off-by: Takashi Yano <[email protected]> >>> + size_t towrite = len; >>> + >>> ssize_t ret; >>> char *p = (char *) ptr; >>> termios &ti = tc ()->ti; >>> @@ -2152,7 +2284,7 @@ fhandler_pty_master::write (const void *ptr, size_t len) >>> If the reply for "CSI6n" is divided into multiple writes, >>> pseudo console sometimes does not recognize it. Therefore, >>> put them together into wpbuf and write all at once. */ >>> - static const int wpbuf_len = strlen ("\033[32768;32868R"); >>> + static const int wpbuf_len = 64; /* for response to CSI6n nad CSIc */ >> >> Is there some macro for the count of 64 in this context, by any chance? > > I'm not sure for now that 64 is really enough for the responce to ESC[c. > mintty returns about 30 byte responce. But some other terminal may return > longer responce. https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h4-Functions-using-CSI-_-ordered-by-the-final-character-lparen-s-rparen:CSI-Ps-c.1CA3 Responses include \e [ ? # # c 6 for base ctl seq plus term type e.g. 64 from mintty; plus ";" separated attributes up to 7 (round to 8) each single digit and 8 double digit => 6 + 16 + 24 <= 46 e.g. for mintty \e[?64;1;2;4;6;9;11;15;21;22;28;29c => 6 + 10 + 18 = 34 Could default to column width if longer to allow room for prompts and titles; max parameter value lengths are 5 digits; text strings may be longer; querying 8/16/88/256 colour palettes or similar could require more space. >>> if [ $(uname -m) = "x86_64" ] >>> then >>> POSTFIX="x64" >>> else >>> POSTFIX="x86" >> >> Do we really want a 32 bit version? Isn't there an aarch64 version? > > No. What should we assume result of "uname -m" in aarch64 machine? WSL should work on ARM and reports of uname say aarch64. -- Take care. Thanks, Brian Inglis Calgary, Alberta, Canada La perfection est atteinte Perfection is achieved non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut -- Antoine de Saint-Exupéry -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple