Re: dynamic conpty loading
Thomas Wolff via Cygwin <[email protected]>
| Newsgroups | gmane.os.cygwin |
|---|---|
| Message-ID | <[email protected]> |
Hi Takashi, Am 12.12.2025 um 09:23 schrieb Thomas Wolff via Cygwin: > Am 11.12.2025 um 23:46 schrieb Takashi Yano via Cygwin: >> On Thu, 11 Dec 2025 15:01:14 +0100 >> Thomas Wolff wrote: >>> Hi Takashi, >>> >>> Am 11.12.2025 um 13:06 schrieb Takashi Yano via Cygwin: >>>> Hi Thomas, >>>> >>>> Thanks for the reply. >>>> >>>> On Thu, 11 Dec 2025 10:45:52 +0100 >>>> Thomas Wolff wrote: >>>>> Hi Takashi, >>>>> sorry, I just saw this mail right now. >>>>> >>>>> Am 06.12.2025 um 22:40 schrieb Takashi Yano via Cygwin: >>>>>> Hi Thomas, >>>>>> >>>>>> On Sat, 6 Dec 2025 18:48:29 +0100 >>>>>> Thomas Wolff wrote: >>>>>>> Am 03.12.2025 um 13:49 schrieb Takashi Yano via Cygwin: >>>>>>>> On Wed, 3 Dec 2025 11:34:01 +0000 (UTC) >>>>>>>> matthew patton wrote: >>>>>>>>> the libopenconsole.postinstall script ihas some glaring issues. >>>>>>>>> >>>>>>>>> * define strings once and then use the variable instead of >>>>>>>>> repeating over and over and over the long-ass path names. >>>>>>>>> >>>>>>>>> * the wget to STDOUT strikes me as pointless. use curl if >>>>>>>>> you're going to resort to that kind of operation. Otherwise >>>>>>>>> just save the .zip to disk already without gratuitous memory >>>>>>>>> buffering >>>>>>>>> >>>>>>>>> * /tmp should not be assumed. use $TMPDIR >>>>>>>>> >>>>>>>>> * use trap to clean up after yourself in both the successful >>>>>>>>> and unsuccessful cases >>>>>>>>> >>>>>>>>> * 'POSTFIX' makes no sense. it's ARCH or PLATFORM >>>>>>>>> >>>>>>>>> * personally I would have versions.txt be a tab deliminted >>>>>>>>> file with version_num\tsha256 of x64\tsha256 of x86 or >>>>>>>>> something along those lines. >>>>>>>> Thanks! >>>>>>> Unfortunately, this does not work for me on Windows 10. >>>>>>> And I cannot test on Windows 11; my previous report was bogus, I >>>>>>> self-compiled the unpatched cygwin1.dll for a cross-test but it >>>>>>> fails. >>>>>>> Running bash from a Windows console, then Cygwin console works, >>>>>>> also >>>>>>> running wsl from there. Running `mintty -h alw` says >>>>>>> The handle is invalid. >>>>>>> Error code: Bash/Service/ERROR_INVALID_HANDLE >>>>>> Thansk for testing. >>>>>> Do you mean `mintty -h alw` works on self-compiled-unpatched >>>>>> cygwin1.dll but does not work on self-compiled-patched cygwin1.dll? >>>>> No, I mean in my Windows 11 system, it failed even with a >>>>> self-compiled >>>>> unpatched cygwin1.dll, right now. >>>>> (I was having cygwin build problems before...) >>>>> So I took a fresh approach, fresh git clone, then followed the >>>>> cumbersome build instructions (which I had put into my own configure >>>>> wrapper and used to work before). >>>>> Not quite understanding the purpose of that package, or the >>>>> postinstall >>>>> script which told me >>>>> cat: /etc/libopenconsole/version.txt: No such file or directory >>>>> sha256sum: >>>>> /etc/libopenconsole/Microsoft.WindowsTerminal__x64.zip.sha256: No >>>>> such >>>>> file or directory >>>>> , I just copied OpenConsole.exe manually into /bin. And yes, now it >>>>> works in Windows 11, even with OpenConsole from WT 1.23 (which is >>>>> a bit >>>>> surprising as there was a bug which they fixed later). >>>>> >>>>> Copied the solution to Windows 10 but unfortunately it does not work >>>>> there. Kind regards Thomas >>>> What happens in Windows 10 case? Does cygwin itself start and it >>>> has a problem when starting non-cygwin app? Or does not start at all? >>> No, wsl was running normally, just the fixes of terminal interworking >>> (esp. character attributes, test file attached) did not work. >>> ... >>> >>>> In my environment, patched cygwin1.dll works under both Win10 and 11. >>> Well, yeah, I gave it a fresh go under Win10 as well and miraculously >>> now it works! >>> With OpenConsole from either 1.23, 1.24 pre-release, or 1.25 "canary". >>> Thanks a lot for making this work. >> Thanks for testing and the test file. >> With mintty 3.8.1, the test script works with the following settings, >> with/without wls in mintty window. >> >> Show bold: as font >> Allow blinking: on >> Show dif as fot: on >> >> Without OpenConsole.exe, "5: text blinking" and "6: text blinking >> rapidly" >> are the same result and "CMYK colour" does not work while all attributes >> work with OpenConsole.exe. > Actually, with the original Windows conhost.exe in $WINDIR/System32 > (size 867KB), > all attributes in the test file except normal blinking are broken for > me; bold is the only one rendered but enforces white colour. > The patch plus OpenConsole.exe fixes this, not only for wsl but also > for Windows console programs, test case > cmd /C type xtextattr1 > > Another test case: > wsl sh -c '/bin/echo -e "\e[c\e[>c"' > >> Thanks! > Thanks to you. Will the patch be available as a cygwin release or > prerelease soon? > Thomas > I'd like to bundle this solution with mintty for the wsltty standalone package. I could bundle a patched version but I'd prefer an official release or at least test release for publishing. I haven't seen this patch yet in the git repository, when will it be ready for cygwin 3.7.0? Thanks, Thomas -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple