Re: Extra align in malloc_mgt_init?

Matthew Dillon <[email protected]> Mon, 17 May 2021 12:40:47 -0900
Newsgroups gmane.os.dragonfly-bsd.kernel
Message-ID <CAOZ7CpALBtDqvEUpy6BJu80yBWsqvBpf9Ns=jEhjp3Xa6MaeKw@mail.gmail.com>
--000000000000fcafc705c28d723f
Content-Type: multipart/alternative; boundary="000000000000fcafc405c28d723d"

--000000000000fcafc405c28d723d
Content-Type: text/plain; charset="UTF-8"

Hmm.  You might be right.  It should work without that first alignment
operation because the (size) is already aligned.  But for safety's sake I
would probably want to change the if() into a while() to allow count to be
adjusted twice if necessary, just to be sure.  The init function is not in
a critical path.  I'll test it out a bit and commit with a credit to you.
Thanks!

-Matt

--000000000000fcafc405c28d723d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div><div>Hmm.=C2=A0 You might be right.=C2=A0 It should w=
ork without that first alignment operation because the (size) is already al=
igned.=C2=A0 But for safety&#39;s sake I would probably want to change the =
if() into a while() to allow count to be adjusted twice if necessary, just =
to be sure.=C2=A0 The init function is not in a critical path.=C2=A0 I&#39;=
ll test it out a bit and commit with a credit to you.=C2=A0 Thanks!</div><d=
iv><br></div><div>-Matt</div></div></div>

--000000000000fcafc405c28d723d--

--000000000000fcafc705c28d723f
Content-Type: text/x-patch; charset="US-ASCII"; name="kmalloc.diff"
Content-Disposition: attachment; filename="kmalloc.diff"
Content-Transfer-Encoding: base64
Content-ID: <f_kot4rb9k0>
X-Attachment-Id: f_kot4rb9k0

ZGlmZiAtLWdpdCBhL3N5cy9rZXJuL2tlcm5fa21hbGxvYy5jIGIvc3lzL2tlcm4va2Vybl9rbWFs
bG9jLmMKaW5kZXggZDIyMmUwNTM4NjkuLjI3YWU0YTgxYWM5IDEwMDY0NAotLS0gYS9zeXMva2Vy
bi9rZXJuX2ttYWxsb2MuYworKysgYi9zeXMva2Vybi9rZXJuX2ttYWxsb2MuYwpAQCAtMjg4LDIx
ICsyODgsMjMgQEAgbWFsbG9jX21ndF9pbml0KHN0cnVjdCBtYWxsb2NfdHlwZSAqdHlwZSBfX3Vu
dXNlZCwKIAogCS8qCiAJICogRmlndXJlIG91dCB0aGUgY291bnQgYnkgdGFraW5nIGludG8gYWNj
b3VudCB0aGUgc2l6ZSBvZiB0aGUgZm9ianNbXQotCSAqIGFycmF5IGJ5IGFkZGluZyBpdCB0byB0
aGUgb2JqZWN0IHNpemUuCisJICogYXJyYXkgYnkgYWRkaW5nIGl0IHRvIHRoZSBvYmplY3Qgc2l6
ZS4gIFRoaXMgaW5pdGlhbCBjYWxjdWxhdGlvbgorCSAqIGlnbm9yZXMgYWxpZ25tZW50IGVkZ2Ut
Y2FzZXMgdGhhdCBtaWdodCByZXF1aXJlIHRoZSBjb3VudCB0byBiZQorCSAqIHJlZHVjZWQuCiAJ
ICovCiAJb2Zmc2V0ID0gb2Zmc2V0b2Yoc3RydWN0IGttYWxsb2Nfc2xhYiwgZm9ianNbMF0pOwot
CW9mZnNldCA9IF9fVk1fQ0FDSEVMSU5FX0FMSUdOKG9mZnNldCk7CiAJY291bnQgPSAoS01BTExP
Q19TTEFCX1NJWkUgLSBvZmZzZXQpIC8gKHNpemUgKyBzaXplb2Yodm9pZCAqKSk7CiAKIAkvKgot
CSAqIEhvd2V2ZXIsIHRoZSBmb2JqW10gYXJyYXkgaXRzZWxmIG11c3QgYmUgYWxpZ25lZCwgc28g
d2UgbWlnaHQKLQkgKiBoYXZlIHRvIHJlZHVjZSB0aGUgY291bnQgYnkgMS4gIChXZSBjYW4gZG8g
dGhpcyBiZWNhdWVzICdzaXplJwotCSAqIGlzIGFscmVhZHkgYWxpZ25lZCBhcyB3ZWxsKS4KKwkg
KiBSZWNhbGN1bGF0ZSB0aGUgb2Zmc2V0IG9mIHRoZSBmaXJzdCBvYmplY3QsIHRoaXMgdGltZSBp
bmNsdWRpbmcKKwkgKiB0aGUgcmVxdWlyZWQgYWxpZ25tZW50LiAgKHNpemUpIHNob3VsZCBhbHJl
YWR5IGJlIGFsaWduZWQuICBUaGlzCisJICogbWF5IHB1c2ggdGhlIGxhc3Qgb2JqZWN0IGJleW9u
ZCB0aGUgc2xhYiBzbyBjaGVjayBhbmQgbG9vcCB3aXRoCisJICogYSByZWR1Y2VkIGNvdW50IGFz
IG5lY2Vzc2FyeS4KIAkgKi8KIAlvZmZzZXQgPSBvZmZzZXRvZihzdHJ1Y3Qga21hbGxvY19zbGFi
LCBmb2Jqc1tjb3VudF0pOwogCW9mZnNldCA9IF9fVk1fQ0FDSEVMSU5FX0FMSUdOKG9mZnNldCk7
CiAKLQlpZiAob2Zmc2V0ICsgc2l6ZSAqIGNvdW50ID4gS01BTExPQ19TTEFCX1NJWkUpIHsKKwl3
aGlsZSAob2Zmc2V0ICsgc2l6ZSAqIGNvdW50ID4gS01BTExPQ19TTEFCX1NJWkUpIHsKIAkJLS1j
b3VudDsKIAkJb2Zmc2V0ID0gb2Zmc2V0b2Yoc3RydWN0IGttYWxsb2Nfc2xhYiwgZm9ianNbY291
bnRdKTsKIAkJb2Zmc2V0ID0gX19WTV9DQUNIRUxJTkVfQUxJR04ob2Zmc2V0KTsKQEAgLTMxMSw2
ICszMTMsMTAgQEAgbWFsbG9jX21ndF9pbml0KHN0cnVjdCBtYWxsb2NfdHlwZSAqdHlwZSBfX3Vu
dXNlZCwKIAogCW1ndC0+c2xhYl9vZmZzZXQgPSBvZmZzZXQ7CiAJbWd0LT5zbGFiX2NvdW50CSA9
IGNvdW50OworCisJa3ByaW50ZigiWFhYIG1ndF9pbml0ICVzIGJhc2Ugb2Zmc2V0ICV6eCBjb3Vu
dCAlemQgKGVuZCAlMDh6eClcbiIsCisJCXR5cGUtPmtzX3Nob3J0ZGVzYywgb2Zmc2V0LCBjb3Vu
dCwgb2Zmc2V0ICsgc2l6ZSAqIGNvdW50KTsKKwogfQogCiB2b2lkCg==
--000000000000fcafc705c28d723f--