Re: Add missing POSIX O_CLOFORK
Matthew Dillon <[email protected]> Wed, 9 Jul 2025 13:59:29 -0700
| Newsgroups | gmane.os.dragonfly-bsd.kernel |
|---|---|
| Message-ID | <CAOZ7CpC0uE_4i1wHMu5Z=pTz3K=BCYG===QhdzDoH+9DmRHLZA@mail.gmail.com> |
--0000000000000c44a40639855bf2 Content-Type: text/plain; charset="UTF-8" Ok, it looks fairly straight-forward. A great deal of work on your part, we really appreciate it! The only question I have is about this line in fsetfdflags(): fdp->fd_files[fd].fileflags = set_flags & 0x7f; What is the mask for? fileflags is a char field more or less but if all you are doing is getting rid of a compiler warning that should probably be a cast instead of a masking operation, with a comment explainer. -Matt --0000000000000c44a40639855bf2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">Ok, it looks fairly straight-forward.=C2=A0 =C2=A0A great = deal of work on your part, we really appreciate it!<div>The only question I= have is about this line in fsetfdflags():<div><br></div><div>fdp->fd_fi= les[fd].fileflags =3D set_flags & 0x7f;<br></div><div><br></div><div>Wh= at is the mask for?=C2=A0 fileflags is a char field more or less but if all= you are doing is getting rid of a compiler warning that should probably be= a cast instead of a masking operation, with a comment explainer.</div><div= ><br></div><div>-Matt</div><div><br></div></div></div> --0000000000000c44a40639855bf2--