Re: [PATCH] The DHCPREQUEST message should contain the same 'xid' as the DHCPOFFER message

Michael Jones <[email protected]> Wed, 12 Feb 2014 07:32:20 -0700
Newsgroups gmane.os.ecos.patches
Message-ID <[email protected]>
Jurgen,

I typically put these in bugzilla with an explanation. That is where people look for patches before they are part of the source tree. As far as I can tell, it is the only way patches become part of the code base.

Mike

On Feb 12, 2014, at 6:08 AM, Lambrecht Jürgen <[email protected]> wrote:

> Hi,
> 
> I found a bug and fixed it, so I don't know if I need to use bugzilla 
> for that?
> In attach the patch.
> 
> file: net/common/current/src/dhcp_prot.c
> 
> According to RFC 2131 (http://www.faqs.org/rfcs/rfc2131.html): "The 
> DHCPREQUEST message contains the same 'xid' as the DHCPOFFER message."
> So in a DHCP DORA cycle (Discover-Offer-Request-Acknowledge) the same 
> transaction ID should be used ('xid' in C code).
> We never had problems with that, but now we have a strict customer..
> 
> Kind regards,
> Jürgen
> 
> -- 
> Jürgen Lambrecht
> R&D Associate
> Mobile: +32 499 644 531
> Tel: +32 (0)51 303045    Fax: +32 (0)51 310670
> http://www.televic-rail.com
> Televic Rail NV - Leo Bekaertlaan 1 - 8870 Izegem - Belgium
> Company number 0825.539.581 - RPR Kortrijk
> 
> <dhcp_prot.patch>