Re: WITHOUT_BZIP2?

Daniel Engberg <[email protected]> writes:
> Lexi Winter <[email protected]> writes:
> > src.conf(5) documents the WITHOUT_BZIP2 knob.   however, unless i'm
> > missing something, this knob doesn't actually do anything, i.e. it
> > has no effect on the built system.
> >=20=20=20=20
> > we could fix this in two ways:
> >=20=20=20=20
> > - actually implement the option, to not build bzip2(1), libz2, etc.
> >=20=20=20=20
> > - remove the option.
> >=20=20=20
> > i am inclined towards the second option, since no one has complained
> > about the option not working, and therefore almost certainly isn't
> > using it.
> Hi, Having pola in mind and the practical impact I think it's safe to
> assume that you don't need to implement a functional variant if it is
> broken, just remove it.  If libarchive (bsdtar) had native builtin
> support perhaps it would be worth considering implement it and/or
> removing the library itself (and move it to a package repo) but that
> doesn't seem to be the case at least not as of writing.

Libarchive has had native support for bzip2 compression since at least
2012.  That, however, is only tangentially related to the BZIP2 option.

We have two build options related to bzip2:

1) The BZIP2_SUPPORT option is supposed to enable / disable support for
   the bzip2 algorithm / file format in various utilities such as tar,
   zcat etc.  It currently only affects zcat (usr.bin/gzip).  It should,
   but does not, also cover libarchive and its consumers, and control
   whether libbz2 is built.

2) The BZIP2 option is supposed to control whether bzip2, bunzip2, and
   bzip2recover are built, but does not.

We should probably drop both options outright, since we've never
provided corresponding options for gzip, xz / lzma, or zstd.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - [email protected]