Re: WITHOUT_BZIP2?

"Enji Cooper (yaneurabeya)" <[email protected]> Fri, 3 Apr 2026 08:25:11 -0700
Newsgroups gmane.os.freebsd.architechture
Message-ID <9CB15D18-A91C-4318-8834-38FE2FF682B6__25930.8013761014$1775229952$gmane$org@gmail.com>
--Apple-Mail=_3D9E0FAF-1A65-467A-AD9C-F5090AADDE3F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Mar 29, 2026, at 9:34=E2=80=AFAM, Dag-Erling Sm=C3=B8rgrav =
<[email protected]> wrote:
>=20
> Daniel Engberg <[email protected]> writes:
>> Lexi Winter <[email protected]> writes:
>>> src.conf(5) documents the WITHOUT_BZIP2 knob.   however, unless i'm
>>> missing something, this knob doesn't actually do anything, i.e. it
>>> has no effect on the built system.
>>>=20
>>> we could fix this in two ways:
>>>=20
>>> - actually implement the option, to not build bzip2(1), libz2, etc.
>>>=20
>>> - remove the option.
>>>=20
>>> i am inclined towards the second option, since no one has complained
>>> about the option not working, and therefore almost certainly isn't
>>> using it.
>> Hi, Having pola in mind and the practical impact I think it's safe to
>> assume that you don't need to implement a functional variant if it is
>> broken, just remove it.  If libarchive (bsdtar) had native builtin
>> support perhaps it would be worth considering implement it and/or
>> removing the library itself (and move it to a package repo) but that
>> doesn't seem to be the case at least not as of writing.
>=20
> Libarchive has had native support for bzip2 compression since at least
> 2012.  That, however, is only tangentially related to the BZIP2 =
option.
>=20
> We have two build options related to bzip2:
>=20
> 1) The BZIP2_SUPPORT option is supposed to enable / disable support =
for
>   the bzip2 algorithm / file format in various utilities such as tar,
>   zcat etc.  It currently only affects zcat (usr.bin/gzip).  It =
should,
>   but does not, also cover libarchive and its consumers, and control
>   whether libbz2 is built.
>=20
> 2) The BZIP2 option is supposed to control whether bzip2, bunzip2, and
>   bzip2recover are built, but does not.
>=20
> We should probably drop both options outright, since we've never
> provided corresponding options for gzip, xz / lzma, or zstd.

	If there was a way to build bootloaders without bzip2 support, =
that could save boot loader blocks for other things. That=E2=80=99s one =
case I can think of where it makes sense making the support work as =
desired.
Thanks!
-Enji


--Apple-Mail=_3D9E0FAF-1A65-467A-AD9C-F5090AADDE3F
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmnP29cACgkQGpE5DjPs
NJgdbQ//Q3DQHO57cXk1Ov3GPD3shaY5rNWqflKvypurioaj5aim+HQYV/1VlWV+
faIo4avMUpDIQf9kABakafYXeOIbxEm5rp6zdpRCO5l2EfRuGh1K9qybTjSAotJ4
0K4aSBY2/DkgLzT7h6WuBMPxCyxW7b8kPrrksy8ylu3Maa0lNxmdI0T5xN7V9QJu
K7OvCWezCo60HSC2XS9novU/GNyzPQ8dWObSMuJmWGODntFqohcoIRgKp+brJPGw
jgIuD3P34j86NheNYfGyviH2waWxW27p1QUVbnSRgOMtcMGpwGNczg/mP9Nb0nqr
+lhGd7ivzvFKxkMrS1E03MDfwHbBrLEOqU6/U5kYfckuqnrKSNYwQTogGYg7wgJL
0LGJKyV8b90yQAvl+QRGA0yYcSEoRVMWnEQ9K4Xet4aELJA2ZSaDtVkhUjpiiShA
++jBtMy1ZFwY+f/PuNUAMam9Lz6g7Lsuxp/zQ7FiSzx9p5goFS0Y3DMtHtPaK/XE
6hDCoG92fVOVlO1rWo9ozon/5WDlbtQ6g7sgS34YgRV7JkgeqGKu+dPz14aO2TRc
r9vGpf8IyP/axbA76gj9jhx7Q5tBbtEfQ2tRb+eeY+Jp7BvUi08H2x1ao5yA9AOd
Y8WnxrQv/b5tnqjdIeLBhXdqF20YNxhtGQ6MWPFb7EGkR6Bw+ak=
=Zx/r
-----END PGP SIGNATURE-----

--Apple-Mail=_3D9E0FAF-1A65-467A-AD9C-F5090AADDE3F--