Build failure in /usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6

David Wolfskill <[email protected]> Wed, 3 Jun 2026 04:07:37 -0700

Newsgroups	gmane.os.freebsd.current
Message-ID	<[email protected]>

(Sorry if this has already been seen & addressed; I don't have ready
access to email archives just now.)

During an in-plpace source-based update from:

FreeBSD freebeast.catwhisker.org 16.0-CURRENT FreeBSD 16.0-CURRENT #592 main-n286328-ea4888e63f6a: Tue Jun  2 11:29:57 UTC 2026     [email protected]:/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC amd64 1600018 1600018

to main-n286341-309fc9f76591

I see:
...
Building /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/subr_clockcalib.o
Building /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/force-dynamic-hack.pico
--- tb_pcib.o ---
/usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' set but not used [-Werror,-Wunused-but-set-variable]
  307 |         int error __diagused;
      |             ^
1 error generated.
*** [tb_pcib.o] Error code 1

make[2]: stopped making "all" in /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC
.ERROR_TARGET='tb_pcib.o'
.ERROR_META_FILE='/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/tb_pcib.o.meta'
.MAKE.LEVEL='2'
MAKEFILE=''
.MAKE.MODE='meta missing-filemon=yes missing-meta=yes silent=yes verbose curdirOk=yes'
_ERROR_CMD='cc -target x86_64-unknown-freebsd16.0 --sysroot=/common/S4/obj/usr/src/amd64.amd64/tmp -B/common/S4/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe  -fno-strict-aliasing  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector-strong  -gdwarf-4 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=gnu17 -Werror /usr/src/sys/dev/thunderbolt/tb_pcib.c; ctfconvert -L VERSION -g tb_pcib.o;'
.CURDIR='/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC'
.MAKE='make'
.OBJDIR='/common/S4/obj/usr/src/amd64.amd64/sys/GENERIC'
.TARGETS='all'
CPUTYPE=''
DESTDIR=''
LD_LIBRARY_PATH=''
MACHINE='amd64'
MACHINE_ARCH='amd64'
MACHINE_CPUARCH='amd64'
MAKEOBJDIRPREFIX=''
....

I will attach the ERROR_META_FILE.

Peace,
david
-- 
David H. Wolfskill                              [email protected]

See https://www.catwhisker.org/~david/publickey.gpg for my public key.

tb_pcib.o.meta (text/plain, 9.5 KB)

# Meta data file /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC/tb_pcib.o.meta
CMD cc -target x86_64-unknown-freebsd16.0 --sysroot=/common/S4/obj/usr/src/amd64.amd64/tmp -B/common/S4/obj/usr/src/amd64.amd64/tmp/usr/bin -c -O2 -pipe  -fno-strict-aliasing  -g -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common   -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/amd64/include -fdebug-prefix-map=./x86=/usr/src/sys/x86/include -fdebug-prefix-map=./i386=/usr/src/sys/i386/include -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float  -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector-strong  -gdwarf-4 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch -Wno-error=tautological-compare -Wno-error=empty-body -Wno-error=parentheses-equality -Wno-error=unused-function -Wno-error=pointer-sign -Wno-error=shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length   -mno-aes -mno-avx  -std=gnu17 -Werror /usr/src/sys/dev/thunderbolt/tb_pcib.c
CMD ctfconvert -L VERSION -g tb_pcib.o
CWD /common/S4/obj/usr/src/amd64.amd64/sys/GENERIC
TARGET tb_pcib.o
OODATE /usr/src/sys/dev/thunderbolt/tb_pcib.c offset.inc assym.inc vnode_if.h acpi_quirks.h feeder_eq_gen.h feeder_rate_gen.h snd_fxdiv_gen.h miidevs.h teken_state.h usbdevs.h usbdevs_data.h rpctlscd.h rpctlssd.h ia32_assym.h acpi_wakecode.h acpi_wakedata.h agp_if.h ata_if.h backlight_if.h card_if.h power_if.h fb_if.h hid_if.h iicbb_if.h iicbus_if.h mdio_if.h miibus_if.h mmcbr_if.h mmcbus_if.h mvs_if.h nvme_if.h pci_if.h pci_iov_if.h pcib_if.h ppbus_if.h sdhci_if.h hdac_if.h ac97_if.h channel_if.h feeder_if.h mixer_if.h mpu_if.h mpufoi_if.h uart_if.h usb_if.h virtio_bus_if.h virtio_if.h virtio_pci_if.h g_part_if.h g_raid_md_if.h g_raid_tr_if.h isa_if.h bus_if.h clock_if.h cpufreq_if.h device_if.h linker_if.h serdev_if.h ifdi_if.h lkpi_iic_if.h cryptodev_if.h xenbus_if.h xenbusb_if.h xenmem_if.h acpi_if.h acpi_wmi_if.h vmbus_if.h irdma_if.h irdma_di_if.h tb_if.h opt_global.h
-- command output --
/usr/src/sys/dev/thunderbolt/tb_pcib.c:307:6: error: variable 'error' set but not used [-Werror,-Wunused-but-set-variable]
  307 |         int error __diagused;
      |             ^
1 error generated.

*** Error code 1

-- filemon acquired metadata --
# filemon version 5
# Target pid 73121
# Start 1780484411.161968
V 5
E 80187 /bin/sh
R 80187 /etc/libmap.conf
R 80187 /var/run/ld-elf.so.hints
R 80187 /lib/libedit.so.8
R 80187 /lib/libc.so.7
R 80187 /lib/libtinfow.so.9
R 80187 /lib/libsys.so.7
R 80187 /usr/share/locale/en_US.UTF-8/LC_COLLATE
R 80187 /usr/share/locale/en_US.UTF-8/LC_CTYPE
R 80187 /usr/share/locale/en_US.UTF-8/LC_MONETARY
R 80187 /usr/share/locale/en_US.UTF-8/LC_NUMERIC
R 80187 /usr/share/locale/en_US.UTF-8/LC_TIME
R 80187 /usr/share/locale/en_US.UTF-8/LC_MESSAGES
F 80187 80190
E 80190 /common/S4/obj/usr/src/amd64.amd64/tmp/legacy/usr/sbin/cc
R 80190 /etc/libmap.conf
R 80190 /var/run/ld-elf.so.hints
R 80190 /usr/lib/libprivateclang.so.21
R 80190 /usr/lib/libprivatellvm.so.21
R 80190 /lib/libz.so.6
R 80190 /usr/lib/libprivatezstd.so.5
R 80190 /usr/lib/libexecinfo.so.1
R 80190 /lib/libncursesw.so.9
R 80190 /lib/libthr.so.3
R 80190 /lib/libc++.so.1
R 80190 /lib/libcxxrt.so.1
R 80190 /lib/libm.so.5
R 80190 /lib/libc.so.7
R 80190 /lib/libgcc_s.so.1
R 80190 /lib/libelf.so.2
R 80190 /lib/libtinfow.so.9
R 80190 /lib/libsys.so.7
R 80190 /usr/src/sys/dev/thunderbolt/tb_pcib.c
R 80190 tb_pcib-9a5096bd.o.tmp
W 80190 tb_pcib-9a5096bd.o.tmp
R 80190 ./opt_global.h
R 80190 ./opt_acpi.h
R 80190 ./opt_thunderbolt.h
R 80190 /usr/src/sys/sys/types.h
R 80190 /usr/src/sys/sys/cdefs.h
R 80190 /usr/src/sys/sys/_decls.h
R 80190 /usr/src/sys/sys/_visible.h
R 80190 ./machine/endian.h
R 80190 ./x86/endian.h
R 80190 /usr/src/sys/sys/_types.h
R 80190 ./machine/_types.h
R 80190 ./x86/_types.h
R 80190 ./machine/_limits.h
R 80190 ./x86/_limits.h
R 80190 /usr/src/sys/sys/_endian.h
R 80190 /usr/src/sys/sys/_offsetof.h
R 80190 /usr/src/sys/sys/_pthreadtypes.h
R 80190 /usr/src/sys/sys/_stdint.h
R 80190 /usr/src/sys/sys/bitcount.h
R 80190 /usr/src/sys/sys/select.h
R 80190 /usr/src/sys/sys/_sigset.h
R 80190 /usr/src/sys/sys/_timeval.h
R 80190 /usr/src/sys/sys/timespec.h
R 80190 /usr/src/sys/sys/_timespec.h
R 80190 /usr/src/sys/sys/param.h
R 80190 /usr/src/sys/sys/_null.h
R 80190 /usr/src/sys/sys/_param.h
R 80190 /usr/src/sys/sys/syslimits.h
R 80190 /usr/src/sys/sys/errno.h
R 80190 /usr/src/sys/sys/time.h
R 80190 /usr/src/sys/sys/_clock_id.h
R 80190 /usr/src/sys/sys/priority.h
R 80190 ./machine/param.h
R 80190 /usr/src/sys/sys/_align.h
R 80190 /usr/src/sys/sys/systm.h
R 80190 /usr/src/sys/sys/callout.h
R 80190 /usr/src/sys/sys/_callout.h
R 80190 /usr/src/sys/sys/queue.h
R 80190 /usr/src/sys/sys/kassert.h
R 80190 /usr/src/sys/sys/stdint.h
R 80190 ./machine/_stdint.h
R 80190 ./x86/_stdint.h
R 80190 ./machine/atomic.h
R 80190 /usr/src/sys/sys/atomic_common.h
R 80190 ./machine/cpufunc.h
R 80190 /usr/src/sys/sys/pcpu.h
R 80190 /usr/src/sys/sys/_cpuset.h
R 80190 /usr/src/sys/sys/_bitset.h
R 80190 /usr/src/sys/sys/_lock.h
R 80190 /usr/src/sys/sys/_mutex.h
R 80190 /usr/src/sys/sys/_sx.h
R 80190 /usr/src/sys/sys/_rmlock.h
R 80190 /usr/src/sys/sys/resource.h
R 80190 ./machine/pcpu.h
R 80190 ./machine/_pmap.h
R 80190 ./machine/segments.h
R 80190 ./x86/segments.h
R 80190 ./machine/tss.h
R 80190 ./machine/pcpu_aux.h
R 80190 /usr/src/sys/sys/kpilite.h
R 80190 ./offset.inc
R 80190 /usr/src/sys/sys/libkern.h
R 80190 /usr/src/sys/sys/kernel.h
R 80190 /usr/src/sys/sys/linker_set.h
R 80190 /usr/src/sys/sys/tslog.h
R 80190 /usr/src/sys/sys/module.h
R 80190 /usr/src/sys/sys/bus.h
R 80190 ./machine/_bus.h
R 80190 /usr/src/sys/sys/_bus_dma.h
R 80190 /usr/src/sys/sys/ioccom.h
R 80190 /usr/src/sys/sys/_eventhandler.h
R 80190 /usr/src/sys/sys/kobj.h
R 80190 /usr/src/sys/sys/devctl.h
R 80190 ./device_if.h
R 80190 ./bus_if.h
R 80190 /usr/src/sys/sys/conf.h
R 80190 /usr/src/sys/sys/malloc.h
R 80190 /usr/src/sys/sys/sysctl.h
R 80190 /usr/src/sys/sys/tree.h
R 80190 /usr/src/sys/sys/lock.h
R 80190 /usr/src/sys/sys/ktr_class.h
R 80190 /usr/src/sys/sys/endian.h
R 80190 ./machine/bus.h
R 80190 ./x86/bus.h
R 80190 ./machine/bus_dma.h
R 80190 ./x86/bus_dma.h
R 80190 /usr/src/sys/sys/bus_dma.h
R 80190 ./x86/busdma_impl.h
R 80190 ./machine/resource.h
R 80190 ./machine/stdarg.h
R 80190 ./x86/stdarg.h
R 80190 /usr/src/sys/sys/_stdarg.h
R 80190 /usr/src/sys/sys/rman.h
R 80190 ./machine/pci_cfgreg.h
R 80190 ./x86/pci_cfgreg.h
R 80190 /usr/src/sys/dev/pci/pcireg.h
R 80190 /usr/src/sys/dev/pci/pcivar.h
R 80190 ./pci_if.h
R 80190 /usr/src/sys/dev/pci/pcib_private.h
R 80190 /usr/src/sys/sys/taskqueue.h
R 80190 /usr/src/sys/sys/_task.h
R 80190 /usr/src/sys/dev/pci/pci_private.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acpi.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/platform/acenv.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/platform/acgcc.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/platform/acfreebsd.h
R 80190 /usr/src/sys/sys/ctype.h
R 80190 /usr/src/sys/sys/stdarg.h
R 80190 ./machine/acpica_machdep.h
R 80190 ./x86/acpica_machdep.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/actypes.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/platform/acenvex.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/platform/acgccex.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acnames.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acexcep.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/actbl.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/actbl1.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/actbl2.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/actbl3.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acoutput.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acrestyp.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acpiosxf.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acpixf.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acconfig.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acbuffer.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/accommon.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acmacros.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/aclocal.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acobject.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acstruct.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acglobal.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/achware.h
R 80190 /usr/src/sys/contrib/dev/acpica/include/acutils.h
R 80190 /usr/src/sys/dev/acpica/acpivar.h
R 80190 ./acpi_if.h
R 80190 /usr/src/sys/sys/ktr.h
R 80190 /usr/src/sys/sys/mutex.h
R 80190 /usr/src/sys/sys/lock_profile.h
R 80190 /usr/src/sys/sys/lockstat.h
R 80190 /usr/src/sys/sys/sdt.h
R 80190 ./machine/sdt_machdep.h
R 80190 /usr/src/sys/sys/power.h
R 80190 /usr/src/sys/sys/selinfo.h
R 80190 /usr/src/sys/sys/event.h
R 80190 /usr/src/sys/sys/abi_types.h
R 80190 /usr/src/sys/sys/sx.h
R 80190 /usr/src/sys/dev/acpica/acpi_pcibvar.h
R 80190 ./machine/md_var.h
R 80190 ./x86/x86_var.h
R 80190 /usr/src/sys/dev/thunderbolt/tb_reg.h
R 80190 /usr/src/sys/dev/thunderbolt/tb_pcib.h
R 80190 /usr/src/sys/dev/thunderbolt/nhi_var.h
R 80190 /usr/src/sys/dev/thunderbolt/nhi_reg.h
R 80190 /usr/src/sys/dev/thunderbolt/tbcfg_reg.h
R 80190 /usr/src/sys/dev/thunderbolt/tb_debug.h
R 80190 ./tb_if.h
D 80190 tb_pcib-9a5096bd.o.tmp
X 80190 1 0
X 80187 1 0
# Stop 1780484411.705969
# Bye bye

signature.asc (application/pgp-signature, 358 B)