Re: PERFORCE change 136345 for review (fwd)

On 2008-02-29 08:08, Tomas Olsson wrote:
> Good idea, maybe an odd place to put it -- unexpected side effect given
> the file/macro name. On the other hand, I have no idea where I would put
> it.

Putting it next to vnode_if.h seems to make sense.  Having
vnode_if.h where it is in arla seems a little odd.  I guess I'd
consider moving both down to somewhere like nnpfs/sys or
nnpfs/kernel or something.  But that's all pretty much just
cosmetics.

> The beautiful long term solution may be adding some kind of lightweight
> 'generate headers' target for the kernel build so external projects
> don't need to reinvent the wheel? Or maybe arla is just a very strange
> one.

Yeah, glancing at the kernel build itself, there's bold symlink
just like what I did;

lrwxr-xr-x  1 root  wheel  25 Jan 25 18:43 machine -> /usr/src/sys/i386/include

It would be nice if either the kernel sources would have
/usr/src/sys/i386/machine or /usr/src/sys/i386/include/machine
instead of ending in include *or* as you suggest a
make-kernel-headers in the kernel itself would be nice and it could
do the symlinking, vnode_if.awk'ing, etc. for people.  But if this
works for you, and Robert doesn't object, let's go with it.  

Robert, any thoughts?  And do you want me to take a whack at
merging nnpfs into the kernel build this weekend?  I'd be jumping
right into the deep end, but that's how you learn to swim, right?

-- 
Alec Kloss  [email protected]   IM: [email protected]
PGP key at http://pgp.mit.edu:11371/pks/lookup?op=get&search=0xA241980E
"No Bunny!" -- Simon, from Frisky Dingo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFHx/+l2s33paJBmA4RApAbAJ47dRvzzPklO8YM/ZqSZCrBETnTCACeL5dC
SOmqd32ovxJzc5ELQK2Pzuc=
=PfoU
-----END PGP SIGNATURE-----