Re: Kmod driver at iicbus. attach() and config_intrhook(9)
John-Mark Gurney <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.arm |
|---|---|
| Message-ID | <[email protected]> |
Michal Meloun wrote this message on Wed, Aug 26, 2020 at 07:39 +0200:
>
>
> On 25.08.2020 22:33, John-Mark Gurney wrote:
> > Andriy Gapon wrote this message on Tue, Aug 25, 2020 at 10:21 +0300:
> >> On 24/08/2020 23:47, John-Mark Gurney wrote:
> >>> What driver is used for i2c on the Orange? I've tried to firgure it
> >>> out from dts + source, but it isn't clear.
> >>
> >> a10_twsi
> >
> > Thanks. And this explains why I couldn't find it in arm/allwinner.. :)
> >
> > Yeah, this is using bus_generic_attach...
> >
> > But it looks like it supports interruptless operation. Is there a flag
> > for when interrupts are enabled?
> >
> > Because the check in sys/dev/iicbus/twsi/twsi.c:twsi_transfer could be
> > changed from:
> > if (sc->have_intr == false)
> >
> > to:
> > if (sc->have_intr == false || interrupts_not_enabled)
> >
> > And that could fix things.
>
> See one of existing drivers for inspiration.
> For example:
> https://svnweb.freebsd.org/base/head/sys/arm64/rockchip/rk_i2c.c?revision=358278&view=markup&pathrev=364777#l528
Ahh, yes, cold. Forgot about that.
yet another thing that should be documented.
--
John-Mark Gurney Voice: +1 415 225 5579
"All that I will do, has been done, All that I have, has not."
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-arm
To unsubscribe, send any mail to "[email protected]"