Re: PinebookPro misc drivers..
Emmanuel Vadot <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.arm |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 10 Mar 2021 15:29:21 +0100 Søren Schmidt <[email protected]> wrote: > Hi > > I?ve uploaded the latest from my PinebookPro collection here: > https://people.freebsd.org/~sos/PinebookPro/ <https://people.freebsd.org/~sos/PinebookPro/> > > Comment,, bugs, etc welcome? Few comments, - Could you at least share patches generated with git diff ? - rk_gpiokeys.c doesn't seems correct, we already have sys/dev/gpio/gpiokeys.c so patch this one if it isn't enough for lid switch need. I could comment more if I would be able to diff more easily. > PS: and no I left my commit bit for safe keeping with core many years ago?. You could still open reviews on phab :) > -- > Søren Schmidt > [email protected] / [email protected] > "So much code to hack, so little time" > > > > _______________________________________________ > [email protected] mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-arm > To unsubscribe, send any mail to "[email protected]" -- Emmanuel Vadot <[email protected]> <[email protected]> _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-arm To unsubscribe, send any mail to "[email protected]"