Re: GPIO pullups not working -- SOLVED (or at least understood) [brcm,bcm2711-gpio in compat_data correct?]

On Sat, May 15, 2021 at 2:43 PM Mark Millard <[email protected]> wrote:

> Does this mean that main's 2551d928501f 2021-02-17 commit of:
>
> diff --git a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> index 61513df9c008..70b69eb154e8 100644
> --- a/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> +++ b/sys/arm/broadcom/bcm2835/bcm2835_gpio.c
> @@ -157,6 +157,7 @@ enum bcm_gpio_pud {
>  static struct ofw_compat_data compat_data[] = {
>         {"broadcom,bcm2835-gpio",       1},
>         {"brcm,bcm2835-gpio",           1},
> +       {"brcm,bcm2711-gpio",           1},
>         {NULL,                          0}
>  };
>
> was inappropriate?
>
>
Assuming that code made it into 13.0-RELEASE then I would say yes because
that release does not correctly control pullups for the 2711.