Re: Quartz64 (RK3566) clock driver and patches.
Søren Schmidt <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.arm |
|---|---|
| Message-ID | <[email protected]> |
Permissions fixed all have access now. What do you mean by more context exactly? It is just a new driver for the pmucru and cru parts of the rk3568, nothing fancy… Btw I need to add Schmitt trigger support to pincontrol any suggestions ? -Søren > On 26 Jul 2021, at 19.50, Emmanuel Vadot <[email protected]> wrote: > > On Sat, 24 Jul 2021 22:17:06 +0200 > Emmanuel Vadot <[email protected]> wrote: > >>> On Sat, 24 Jul 2021 19:46:20 +0200 >>> Søren Schmidt <[email protected]> wrote: >>> >>>> On 24 Jul 2021, at 13.56, Emmanuel Vadot <[email protected] <mailto:[email protected]>> wrote: >>> >>>>> >>>>> On Sat, 24 Jul 2021 13:26:07 +0200 >>>>> Søren Schmidt <[email protected] <mailto:[email protected]>> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> As promised, the clk driver I did for the RK3566 used on the Pine Quartz64 board: >>>>>> >>>>>> https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~sos/Q64/> <https://people.freebsd.org/~sos/Q64/ <https://people.freebsd.org/~sos/Q64/>> >>>>>> >>>>>> Included the buld script, kernel config and u-boot I have used to get there. >>>>> >>>>> That will be much easier to review on phab, or even github PR or git >>>>> send-email, basically anything else that this raw diff. >>>>> >>> >>> So for your entertainment I just uploaded the patch to fabricator, however I dont see how that changes anything but the colors :) >> >> That will make me look more closely to the patches :) >> >> Thanks, >> >>> >>> -- >>> Søren Schmidt >>> [email protected] / [email protected] >>> "So much code to hack, so little time" >>> >>> >>> >> >> >> -- >> Emmanuel Vadot <[email protected]> <[email protected]> >> > > I cannot add comment to the review : > You Shall Not Pass: D31299 > You do not have permission to edit this object. > > Looks like you added a custom policy : "sos created this object with > edit policy "sos (Søren Schmidt)"." > > Please remove it and also if you could upload diff with more context > too. > > -- > Emmanuel Vadot <[email protected]> <[email protected]>