Re: U-boot on RPI3, sees disk but won't boot it

On 2022-Sep-21, at 10:50, bob prohaska <[email protected]> wrote:

> On Wed, Sep 21, 2022 at 09:17:31AM -0700, Mark Millard wrote:
>> 
>>> On Mon, Sep 19, 2022 at 05:26:08PM -0700, Mark Millard wrote:
>>>> 
>>>> U-Boot resets the bus, re-enumerates the  devices, etc. This
>>>> can time out or otherwise fail despite prior activity by the
>>>> RPi* firmware that managed to use the device.
>>>> 
>>>> My NVMe USB SSD media have such issues with RPI4B's, also
>>>> getting 0 found in U-Boot. This is why I build U-Boot using
>>>> the patch:
>>>> 
>>>> # more /usr/ports/sysutils/u-boot-rpi-arm64/files/patch-include_configs_rpi.h 
>>>> --- include/configs/rpi.h.orig  2022-01-22 06:03:55.862541000 -0800
>>>> +++ include/configs/rpi.h       2022-01-22 06:03:05.435341000 -0800
>>>> @@ -210,6 +210,8 @@
>>>> 	ENV_DEVICE_SETTINGS \
>>>> 	ENV_DFU_SETTINGS \
>>>> 	ENV_MEM_LAYOUT_SETTINGS \
>>>> +	"usb_pgood_delay=2000\0" \
>>>> +	"usb_ready_retry=5\0" \
>>>> 	BOOTENV
>>>> 
>>>> 
>>>> 
>>> 
> 
> I seem to have fumbled the attempt at replicating your patch. It's
> recognized but fails with:
> 
> ===>  Applying extra patch patches for u-boot-rpi-arm64-2022.04_1 from /usr/ports/sysutils/u-boot-rpi-arm64/files/
> No such line 209 in input file, ignoring
> 1 out of 1 hunks failed--saving rejects to include/configs/rpi.h.rej
> ===>  FAILED Applying extra patch patch-include_configs_rpi.h
> ===> FAILED to apply cleanly extra patch patch(es)  patch-include_configs_rpi.h
> *** Error code 1
> 
> If I open the local patch with 
> vi /usr/ports/sysutils/u-boot-rpi-arm64/files/patch-include_configs_rpi.h
> it's displayed as:
> 
> --- include/configs/rpi.h.orig  2022-01-22 06:03:55.862541000 -0800
> +++ include/configs/rpi.h       2022-01-22 06:03:05.435341000 -0800
> @@ -210,6 +210,8 @@
>        ENV_DEVICE_SETTINGS \
>        ENV_DFU_SETTINGS \
>        ENV_MEM_LAYOUT_SETTINGS \
> +       "usb_pgood_delay=2000\0" \
> +       "usb_ready_retry=5\0" \
>        BOOTENV

The lines that begin with spaces should instead begin with
a space and then a tab instead. (Whitespace does not
necessarily survive unchanged through E-mail or such.)
The space is not from the patched file but the tab is:
the first column is a form of instruction indicating
what to do for the line.

There should be 2 more lines after the "BOOTENV" line. Each
has just one space. The 8 in "+210,8" indicates how many
lines below are for the specific line replacements. So
there should be 8 lines. The lines with the "+" then tab
sequence are new lines. The ones with a leading space
should have the text after the space matching the original
file content: no change but checks for matching context.
A "-" then tab line would be for deleting a line if it
matches.

Similar points go for the other two patches that I sent in
later E-mail.

I'm unsure about the "No such line 209 in input file, ignoring"
message details. But I'd not sorry until the patch file
is correct.

> The text was transferred from your email to vi using copy-paste. 
> The ports were updated last night, might that be the problem? 
> Prior to adding the new patch u-boot-rpi-arm64 built successfully.

My ports tree is as of:

# ~/fbsd-based-on-what-commit.sh -C /usr/ports/
branch: main
merge-base: 7e8044bf1f9999f77ac2e1fc2e688df9250dc9ae
merge-base: CommitDate: 2022-09-13 06:28:06 +0000
7e8044bf1f99 (HEAD -> main, freebsd/main, freebsd/HEAD) graphics/drm-510-kmod: Update to drm_v5.10.113_7
n595518 (--first-parent --count for merge-base)

u-boot-rpi-arm64 has not changed since:

author	Emmanuel Vadot <[email protected]>	2022-05-02 15:15:40 +0000
committer	Emmanuel Vadot <[email protected]>	2022-05-03 08:10:43 +0000

u-boot-rpi3 has not changed since:

author	Emmanuel Vadot <[email protected]>	2022-05-02 15:15:40 +0000
committer	Emmanuel Vadot <[email protected]>	2022-05-03 08:10:43 +0000

u-boot-rpi4 has not changed since:

author	Emmanuel Vadot <[email protected]>	2022-05-02 15:15:40 +0000
committer	Emmanuel Vadot <[email protected]>	2022-05-03 08:10:43 +0000

u-boot master has not chnaged since:

author	Tobias Kortkamp <[email protected]>	2022-09-10 17:41:16 +0000
committer	Stefan Eßer <[email protected]>	2022-09-10 17:41:16 +0000

===
Mark Millard
marklmi at yahoo.com