Re: Zynq 7 drivers source code location
Tomek CEDRO <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.arm |
|---|---|
| Message-ID | <CAFYkXjm9-3nc5GZxYOmCNaJXgQ0z4LfKBx29=oSQt4pY0GEQBw@mail.gmail.com> |
On Tue, Jun 24, 2025 at 4:53 PM Milan Obuch <[email protected]> wrote: > > On Tue, 24 Jun 2025 08:27:14 +0000 > Michał Kruszewski <[email protected]> wrote: > > > Hello, > > > > Most source codes for drivers for Zynq 7 are placed in the > > sys/arm/xilinx directory. However, some of them are not platform > > specific, as they are generic drivers from Cadence, for example, > > UART, SPI. In such a case, shouldn't they be placed in > > sys/dev/cadence directory? > > > > Things are even more complicated... we have sys/dev/uart directory, > where many UART devices reside, we have sys/dev/spibus with controller > subdirectory and there are allwinner and rockchip next-level > subdirectories. > > Another example: sdhci_fdt_xilinx.c file is located in sys/dev/sdhci > directory. > > To me, this is something without clear rules and clear leadership. I > would not object if things got somehow better organized, I see some > resistance against such changes. There needs to be well reasoned and > well communicated case for this to proceed into repository... > > Regards, > Milan +1 I guess by-function is good organization :-) -- CeDeROM, SQ7MHZ, http://www.tomek.cedro.info