Re: [Bug 292695] rpi3b+ muge0 panic on shutdown

On 1/26/26 07:00, Warner Losh wrote:
> 
> 
> On Mon, Jan 26, 2026 at 1:41 AM Alex Samorukov <[email protected]
> <mailto:[email protected]>> wrote:
> 
> 
>     On 26.01.2026 8:24, Adrian Chadd wrote:
>     >> Kindly asking to review and merge if possible,
>     >>
>     >> https://bz-attachments.freebsd.org/attachment.cgi?id=267455
>     <https://bz-attachments.freebsd.org/attachment.cgi?id=267455>
>     > hi!
>     >
>     > Hm! So, is the panic because the callout is running during shutdown?
>     > Chances are you want to set the flag early in detach, and then go
>     > through the shutdown
>     > path of cancel/draining the poll callout, it should catch it 100%
>     > without needing the pause!
> 
>     Hi Adrian. Thank you for review and you absolutely right, USB draining
>     eliminates need for the pause
> 
>     I updated both patches:
> 
>     https://bugs.freebsd.org/bugzilla/attachment.cgi?
>     id=267497&action=diff <https://bugs.freebsd.org/bugzilla/
>     attachment.cgi?id=267497&action=diff>
> 
>     https://bugs.freebsd.org/bugzilla/attachment.cgi?
>     id=267496&action=diff <https://bugs.freebsd.org/bugzilla/
>     attachment.cgi?id=267496&action=diff>
> 
> 
> Both those patches look good to me. Adrian?
> 
> Warner 

Do any of the other 7 sys/dev/usb/net/if_*.c using mii_pollstat need
similar changes?

# grep -rl mii_pollstat /usr/src/sys/dev/usb/net/ | sort
/usr/src/sys/dev/usb/net/if_aue.c
/usr/src/sys/dev/usb/net/if_axe.c
/usr/src/sys/dev/usb/net/if_axge.c
/usr/src/sys/dev/usb/net/if_mos.c
/usr/src/sys/dev/usb/net/if_muge.c
/usr/src/sys/dev/usb/net/if_rue.c
/usr/src/sys/dev/usb/net/if_smsc.c
/usr/src/sys/dev/usb/net/if_udav.c
/usr/src/sys/dev/usb/net/if_ure.c


-- 
===
Mark Millard
marklmi at yahoo.com