Re: Porting to Snapdragon 8cx SoC [Really: "Add QCOM XHCI HIDS and child node parsing"]

On 1/26/26 23:00, Ludovic Hirlimann wrote:
> On 1/26/26 8:50 PM, Gabe Bauer wrote:
>> I submitted a pull request to handle ACPI devices as handled in the
>> OpenBSD source tree.
>>
>> https://github.com/freebsd/freebsd-src/pull/1971
>>
> I believe you need to follow a process to get a review at https://
> reviews.freebsd.org/.

That is probably a question for imp@ (Warner Losh) for the pull request
titled:

"Add QCOM XHCI HIDS and child node parsing - in OBSD source tree for
Snapdragon 8cx #1971"

Contributing to that judgment may be that it is the author's first time
OS contribution for FreeBSD, quoting gjbauer:

"OpenBSD added these HIDs in a commit to expand support for the
Snapdragon 8cx Gen 3 ARM64 SoC. I added them to the source tree and
implemented the child node parsing logic in the XHCI code. Check out the
full commit here. I am new to FreeBSD contribution. I would like to
learn more!!"

(The "here" was pointing to the OpenBSD commit that he based things on.)

There already is a review comment in the Conversation. Also, clausecker
previously gave a thumbs up to the effort.

> 
> 
> Ludo
> 
> -- 
> https://ludovic.hirlimann.net
> https://piaille.fr/@usul
> https://pix.diaspodon.fr/i/web/profile/41
> 


-- 
===
Mark Millard
marklmi at yahoo.com