Re: [CFT/Review] DPAA2 SFP+, LX2160A eSDHC, Thunderbolt bridge, FreeBSD on Apple Silicon (vz), arm64 16K pages
Warner Losh <[email protected]> Tue, 14 Jul 2026 17:11:15 -0600
| Newsgroups | gmane.os.freebsd.devel.arm |
|---|---|
| Message-ID | <CANCZdfpEidQjLj36A748gd2H44J8qc_T_uFD4jWnWew7a394LA@mail.gmail.com> |
--000000000000945c5806569a5370 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2026 at 1:28=E2=80=AFPM Dmitry Salychev <[email protected]> w= rote: > Adrian Chadd <[email protected]> writes: > > > On Mon, 6 Jul 2026 at 16:39, =E5=AD=94=E7=A5=A5=E6=B3=A2 <yarshure@gmai= l.com> wrote: > >> > >> > >> Hi hackers, > >> > >> I'd like to share a few things I've been working on recently around > >> FreeBSD/arm64, and I'm looking for testers and code review before > >> attempting to upstream the relevant parts. > >> > >> 1) DPAA2: SFP+ now works on LX2160A (runtime configuration support) > >> > >> > https://github.com/freebsd/freebsd-src/compare/main...networkextension:fr= eebsd-src:dpaa2-runtime-config > >> > > > > hi! > > > > This looks good (and dsl@ already replied, which is a good sign.) > > > > I think it'd be good to get this up as a specific review candidate / > > pull request so dsl@, jhibbits@, bz@ and others can > > dig into it some more. > > > > > > > > -adrian > > I'm pretty sure that code was generated by LLM and the project's opinion > regarding such "implementation" is clear IIRC. Personally, I wouldn't > want to spend my time reviewing changes which won't be accepted anyway. > I don't think the project has a coherent view about LLM genreated code. There's no prohibition, core hasn't announced any bans, etc. There was much fear about issues that turned out to not be issues. I've personally landed a dozen changes that were at least assisted by LLM that I drove to completion. I've landed a bunch more where different code completion tools were used, which is a weaker version of LLM generated. IMHO, The current 'center of opinion' seems to be that thoughtful use of LLM is OK, as long as the results meet our minimum quality standards. There's also a strong undercurrent of "and the submitter has to understand it well enough to maintain the code" as well, which is something the review process should probe (but that's no diffferent than what I do with completely human generated code: why did you do this and not that? etc). So the code could be accepted, if it meets the stringent quality demands of FreeBSD. Warner > However, I'm open to consider other points of view. > > Regards, > Dmitry > > -- > https://wiki.freebsd.org/DmitrySalychev > > --000000000000945c5806569a5370 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g= mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Jul 14,= 2026 at 1:28=E2=80=AFPM Dmitry Salychev <<a href=3D"mailto:dsl@freebsd.= org">[email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quo= te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204= );padding-left:1ex">Adrian Chadd <<a href=3D"mailto:[email protected]" = target=3D"_blank">[email protected]</a>> writes:<br> <br> > On Mon, 6 Jul 2026 at 16:39, =E5=AD=94=E7=A5=A5=E6=B3=A2 <<a href= =3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>>= wrote:<br> >><br> >><br> >> Hi hackers,<br> >><br> >> I'd like to share a few things I've been working on recent= ly around<br> >> FreeBSD/arm64, and I'm looking for testers and code review bef= ore<br> >> attempting to upstream the relevant parts.<br> >><br> >> 1) DPAA2: SFP+ now works on LX2160A (runtime configuration support= )<br> >><br> >>=C2=A0 =C2=A0 <a href=3D"https://github.com/freebsd/freebsd-src/com= pare/main...networkextension:freebsd-src:dpaa2-runtime-config" rel=3D"noref= errer" target=3D"_blank">https://github.com/freebsd/freebsd-src/compare/mai= n...networkextension:freebsd-src:dpaa2-runtime-config</a><br> >><br> ><br> > hi!<br> ><br> > This looks good (and dsl@ already replied, which is a good sign.)<br> ><br> > I think it'd be good to get this up as a specific review candidate= /<br> > pull request so dsl@, jhibbits@, bz@ and others can<br> > dig into it some more.<br> ><br> ><br> ><br> > -adrian<br> <br> I'm pretty sure that code was generated by LLM and the project's op= inion<br> regarding such "implementation" is clear IIRC. Personally, I woul= dn't<br> want to spend my time reviewing changes which won't be accepted anyway.= <br></blockquote><div><br></div><div>I don't think the project has a co= herent view about LLM genreated code. There's</div><div>no prohibition,= core hasn't announced any bans, etc. There was much fear about</div><d= iv>issues that turned out to not be issues.</div><div><br></div><div>I'= ve personally landed a dozen changes that were at least assisted by LLM</di= v><div>that I drove to completion. I've landed a bunch more where diffe= rent code completion</div><div>tools were used, which is a weaker version o= f LLM generated. IMHO,=C2=A0<span style=3D"background-color:transparent">Th= e current</span></div><div><span style=3D"background-color:transparent">= 9;center of opinion' seems to be that thoughtful use of </span>LLM<span= style=3D"background-color:transparent"> is OK,=C2=A0</span><span style=3D"= background-color:transparent">as long as the</span></div><div><span style= =3D"background-color:transparent">results meet our minimum quality standard= s. There's also a strong undercurrent of</span></div><div><span style= =3D"background-color:transparent">"and the submitter has to understand= it well enough to maintain the code" as well,</span></div><div>which = is something the review process should probe (but that's no diffferent = than</div><div>what I do with completely human generated code: why did you = do this and not</div><div>that? etc).</div><div><span style=3D"background-c= olor:transparent"><br></span></div><div><span style=3D"background-color:tra= nsparent">So the code could be accepted, if it meets the stringent quality = demands of FreeBSD.</span></div><div><span style=3D"background-color:transp= arent"><br></span></div><div><span style=3D"background-color:transparent">W= arner</span></div><div><span style=3D"background-color:transparent">=C2=A0<= /span></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0= .8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> However, I'm open to consider other points of view.<br> <br> Regards,<br> Dmitry<br> <br> -- <br> <a href=3D"https://wiki.freebsd.org/DmitrySalychev" rel=3D"noreferrer" targ= et=3D"_blank">https://wiki.freebsd.org/DmitrySalychev</a><br> <br> </blockquote></div></div> --000000000000945c5806569a5370--