Re: %j for printf(9)

Bruce Evans <[email protected]> writes:
> I don't remember all the context for this.  Is everything restructured so
> that all the va_arg()'s for fetching integers are in the above patch?

Yes.

> If so, consider the following further restructurings:
> 
> - merge fetch_nosign with nosign (rename it to something like
>   handle_unsigned) and use it handle all the unsigned cases that are now
>   handled by fetch_number.
> - rename fetch_number to handle_signed and use it for only the signed cases
>   (%d and %+z).

These two would actually increase code duplication.

> - don't bother explicitly casting to uintmax_t for the signed cases.  In
>   -current, these casts are used for %+z but not for %d.

OK.

DES
-- 
Dag-Erling Smorgrav - [email protected]

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message