Re: [PATCH] making dump EINTR resistant

At 7:10 PM -0600 6/4/02, Todd C. Miller wrote:
>In message <p05111726b923006f0c07@[128.113.24.47]>
>	so spake Garance A Drosihn (drosih):
>
>>  Would it be acceptable to add EINTR-type checks to freebsd-ish
>>  code?  There are some sections of lpr/lpd which do not work
>>  right when compiled on other platforms, unless I add EINTR
>>  checks at the right places.
>
>It would probably be better to just make the code in question to
>just use sigaction() if you are concerned about portability.  That
>way you get consistent handling of syscall restarts.
>
>Alternately, you could #define signal to bsd_signal when compiling
>on non-BSD platforms.  That is not quite as portable though.

Ah.  Actually I also wrote updates to use sigaction(), but I
did that sometime after I had added the EINTR's around various
system routines.  It sounds like I shouldn't need the EINTR's
anymore, but I just didn't realize it.  I'll try going that
route instead.  That sounds much better.  Thanks.

(I'm still trying to unravel all the various updates I've
added to lpr at RPI over the years...)

-- 
Garance Alistair Drosehn            =   [email protected]
Senior Systems Programmer           or  [email protected]
Rensselaer Polytechnic Institute    or  [email protected]

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message