Re: Minor change to rusers (Was: Re: minor header change in src/bin/dd/misc.c)

On 2002-06-21 00:25 +0000, Joachim Str?mbergson wrote:
>Mike Barcroft wrote:
>> Giorgos Keramidas <[email protected]> writes:
>>>The source of bin/dd/misc.c doesn't use any of the functions of
>>><strings.h> but uses strlen, which is defined in <string.h>.  The
>>>following seems to fix the only warning this file triggers for me.
>>>Does it seem ok to you all?
>>
>> Yes, it's correct.  <strings.h> is almost always wrong for BSD code.
>> I removed the include of <string.h> from <strings.h> when I cleaned up
>> those headers for POSIX compatibility, so there are probably other
>> mis-includes throughout the system.
>
> It seems that this applies to /usr/bin/rusers too. AFAIK the compilation
> goes through and the behaviour seems to be unaltered. How about this patch?

This is already in -CURRENT.  It can probably me MFC'ed but I don't
have a STABLE machine running the r-series of programs to test this.

Seems OK to me though...

- Giorgos


To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message