Re: chpass WARNS/lint fixes
Mark Murray <[email protected]>
| Newsgroups | gmane.os.freebsd.devel.audit |
|---|---|
| Message-ID | <[email protected]> |
> > @@ -39,10 +39,11 @@
> >
> > #ifndef lint
> > static const char sccsid[] = "From: @(#)chpass.c 8.4 (Berkeley) 4/2/94";
> > -static const char rcsid[] =
> > - "$FreeBSD: src/usr.bin/chpass/chpass.c,v 1.20 2002/03/22 01:19:26 imp Exp $";
> > #endif /* not lint */
>
> The vendor ID should be restored from Rev 1.1 and then wrapped in
> #if 0 ... #endif.
There is a __FBSDID() a little later. Or are you talking about $Id$ from the
original code?
> > +
> > +struct dom_binding {};
> > +
>
> This seems bogus; what is it used for?
Nothing. It is bogus. :-)
> The rest looks okay.
Take 2 is on its way.
M
--
o Mark Murray
\_
O.\_ Warning: this .sig is umop ap!sdn
To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message