Re: bin/ln & WARNS=5

In message: <[email protected]>
            Giorgos Keramidas <[email protected]> writes:
: On 2002-07-15 13:37 +0000, Dag-Erling Smorgrav wrote:
: > Giorgos Keramidas <[email protected]> writes:
: > > What's wrong with sizeof(...)?  I thought that style(9) was actually
: > > encouraging the use of parentheses for the arguments of sizeof, when
: > > it mentioned:
: > > 
: > >      Casts and sizeof's are not followed by a space.  Note that
: > >      indent(1) does not understand this rule.
: > 
: > There are two different cases - one is "sizeof(type)" which requires
: > parentheses, the other is "sizeof variable" which doesn't.  In the
: > latter case, the rule about avoiding unnecessary parentheses applies.

That's not always the case.  sizeof type always works too.  The
convention is that sizeof(foo) is done in BSD sources.

: Ah !  [ enlightenment ]
: 
: That would require a major style sweep in ln.c though.  Such changes
: should be done in a separate commit, right?

Yes, they are done with a separate commit, but not when it is the
wrong thing to do.  Leave sizeof(var) alone please.

Warner

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message