Re: bin/ln & WARNS=5

On Mon, 15 Jul 2002, M. Warner Losh wrote:

> In message: <[email protected]>
>             Bruce Evans <[email protected]> writes:
> : That is a bug in 7+ kloc.  No so very old code like src/bin/ln (together
> : with most of src/bin and large parts of src/{sbin,usr.bin,usr.sbin}
> : was obviously cleaned up to have a common style in 4.4BSD or earlier.
> : Equally obviously, the cleanup didn't get as far as src/games.
>
> So would you agree with:
>
> Index: style.9
> ===================================================================
> RCS file: /cache/ncvs/src/share/man/man9/style.9,v
> retrieving revision 1.87
> diff -u -r1.87 style.9
> --- style.9     2 Jul 2002 01:39:35 -0000       1.87
> +++ style.9     15 Jul 2002 18:15:58 -0000
> @@ -520,6 +520,13 @@
>  Note that
>  .Xr indent 1
>  does not understand this rule.
> +.Ic sizeof Ns 's
> +are written like function calls always.
> +The redundant parenthesis rules do not apply to
> +.Ic sizeof(var)
> +instances.
> +Some code in the tree does not follow the last part of this rule.
> +Do not change it gratuitously to do so.
>  .Pp
>  .Dv NULL
>  is the preferred null pointer constant.
>

OK.  One of the many inconsistencies in style.9 was that it says that
casts are "not followed by a space" (so "sizeof foo" is not permitted)
and that parentheses must not be used "unless they are required for
precedence or ..." (so "sizeof foo" is required).

Bruce


To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message