Re: Linuxlator patches for review [was: Who currently maintains Linuxlator?]

On Tue, Oct 08, 2002 at 02:14:58PM +0300, Maxim Sobolev wrote:
> See attached. As it was suggested, I'm also CC'ing marcel,
> freebsd-audit and freebsd-emulation. I'd like to hear any suggestion
> or comments. Please note that changes were not tested on alpha,
> because I don't have any axp hardware.

I can test on Alpha, provided the patch is against -current. Do you
have some test cases?

>  /*
> + * VFAT
> + */
> +#define	LINUX_VFAT_READDIR_BOTH	0x7201
> +
> +#define	LINUX_IOCTL_VFAT_MIN	LINUX_VFAT_READDIR_BOTH
> +#define	LINUX_IOCTL_VFAT_MAX	LINUX_VFAT_READDIR_BOTH
> +
> +/*

Silly question: The VFAT ioctl is not implemented. Is there a bigger
picture?
Also: is it worth having a VFAT handler if there's only 1 ioctl (again,
there might be a bigger picture)?

>  	case LINUX_IPC_INFO:
>  	case LINUX_SEM_INFO:
> -		error = copyin((caddr_t)args->arg.buf, &linux_seminfo, 
> -						sizeof(linux_seminfo) );
> -		if (error)
> -			return error;
>  		bcopy(&seminfo, &linux_seminfo, sizeof(linux_seminfo) );
>  /* XXX BSD equivalent?
>  #define used_semids 10


Should the copyin be replaced with something or was the copyin bogus?

Other than that: looks good. I merely skimmed over it, so I may have
missed a detail....

-- 
 Marcel Moolenaar	  USPA: A-39004		 [email protected]

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message