Re: (fwd) bin/47196: ipfw won't format correctly output from 'ipfw show' command

On Fri, Jan 24, 2003 at 08:02:38PM +0300, Maxim Konovalov wrote:
> On 21:53+0200, Jan 23, 2003, Giorgos Keramidas wrote:
> 
> > On 2003-01-23 19:10, Maxim Konovalov <[email protected]> wrote:
> > > On 05:40+0200, Jan 23, 2003, Giorgos Keramidas wrote:
> > > > I've sent the following 2 days ago to ipfw@ but received no reply.
> > > > Does anyone feel like testing/reviewing or committing this?  This
> > > > change should be all we need to fix & close PR bin/47196 :-)
> > >
> > > Formatting was broken in rev. 1.103 ipfw.c in -CURRENT and ipfw2
> > > in -CURRENT and -STABLE inherited the bug later.
> > >
> > > I think we should rever this part of rev. 1.103 of ipfw.c in ipfw2.c:
> >
> > Not quite.  See inline comments.
> 
> Yes, you are right. Revert 1.103 a little more. Note we always show
> packets/bytes for dynamic rules.
> 
> Index: ipfw2.c
> ===================================================================
> RCS file: /home/ncvs/src/sbin/ipfw/ipfw2.c,v
> retrieving revision 1.21
> diff -u -r1.21 ipfw2.c
> --- ipfw2.c	12 Jan 2003 03:31:10 -0000	1.21
> +++ ipfw2.c	24 Jan 2003 16:34:48 -0000
> @@ -802,7 +802,7 @@
>  }
> 
> @@ -1557,7 +1557,7 @@
>  	ipfw_dyn_rule *dynrules, *d;
> 
>  	void *lim, *data = NULL;
> -	int n, nbytes, nstat, ndyn;
> +	int bcwidth, n, nbytes, nstat, ndyn, pcwidth, width;
                       ^^^^^^^^^^^^^^^^^^
Alphabetic: 
bcwidth, n, nbytes, ndyn, nstat, pcwidth, width;

>  	int exitval = EX_OK;
>  	int lac;
>  	char **lav;

-- 

Rgdz,                        /"\  ASCII RIBBON CAMPAIGN
Sergey Osokin aka oZZ,       \ /    AGAINST HTML MAIL
http://ozz.pp.ru/             X          AND NEWS
                             / \

To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message