Re: WARNS = 2, sbin/ping...

On Sun, 9 Feb 2003, Dag-Erling Smorgrav wrote:

> Sean Chittenden <[email protected]> writes:
> > Speaking of WARNS2, here's a patch that bumps ping(8) to WARNS2.  Once
> > upon a tie it used to be WARNS5, but the patch has rotted some.  The
> > biggie in this one was collisions with sin(3) and sockaddr_in variable
> > sin.
>
> That's a compiler bug (unless <math.h> is in scope).  The correct
> solution is not to rename the variable, but to add -fno-builtin to
> CFLAGS globally, and fix those parts of the tree that break due to
> missing includes.  Who knows, we might even uncover libc bugs that
> have been hitherto been masked by the compiler.

Script started on Mon Feb 10 02:42:09 2003
ttyp0:bde@besplex:/tmp> grep math.h /usr/src/sbin/ping/ping.c
#include <math.h>
ttyp0:bde@besplex:/tmp> exit

Script done on Mon Feb 10 02:42:22 2003

[wollman added this include long ago to support printing standard deviations.]

Bruce


To Unsubscribe: send mail to [email protected]
with "unsubscribe freebsd-audit" in the body of the message